Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

DOC: Add status badges to README file #138

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

jhlegarreta
Copy link
Collaborator

@jhlegarreta jhlegarreta commented Mar 21, 2024

  • DOC: Add status badges to README file
  • DOC: Make README refs be considered as citations instead of footnotes
  • DOC: Use URL as path to static content in README

@jhlegarreta
Copy link
Collaborator Author

README.rst Outdated Show resolved Hide resolved
Add miscellaneous status badges to `README` file:
- License
- PyPI version
- Documentation
- Python package
@jhlegarreta jhlegarreta force-pushed the AddMiscStatusBadgesToREADME branch from 38dc24a to 4a66668 Compare March 22, 2024 14:03
@jhlegarreta
Copy link
Collaborator Author

Doc failure is again unrelated: cross-ref #138 (comment)

@oesteban
Copy link
Member

Doc failure is again unrelated: cross-ref #138 (comment)

I believe this failure is here to stay -- looks like sphinx was just bumped or similar, but this is complaining that the references are not anymore interpreted as part of the document - we should move them from footnotes (which is how they are interpreted at the moment) into citations (which is what we should do, IMHO).

Make references in README be considered as citations instead of
footnotes.

Fixes:
```
Warning, treated as error:
/home/runner/work/eddymotion/eddymotion/README.rst:17:Footnote [1] is not referenced.
make: *** [Makefile:65: html] Error 2
```

raised for example in:
https://github.com/nipreps/eddymotion/actions/runs/8376155506/job/22935185353?pr=138#step:6:54
@jhlegarreta
Copy link
Collaborator Author

The error is now another one unrelated to the references:

Warning, treated as error:
/home/runner/work/eddymotion/eddymotion/README.rst::image file not readable: docs/_static/eddymotion-flowchart.svg
make: *** [Makefile:65: html] Error 2

https://github.com/nipreps/eddymotion/actions/runs/8391856943/job/22983140234?pr=138#step:6:54

@jhlegarreta
Copy link
Collaborator Author

#138 (comment) fixed in 6f8bb9a.

Use commit raw content URL as path to static content in `README`.

Fixes:
```
Warning, treated as error:
/home/runner/work/eddymotion/eddymotion/README.rst::image file not readable:
docs/_static/eddymotion-flowchart.svg
make: *** [Makefile:65: html] Error 2
```

raised for example in:
https://github.com/nipreps/eddymotion/actions/runs/8391856943/job/22983140234#step:6:54
@jhlegarreta jhlegarreta force-pushed the AddMiscStatusBadgesToREADME branch from 6f8bb9a to d3a6b0a Compare March 22, 2024 14:55
@oesteban oesteban merged commit a35b36a into nipreps:main Mar 28, 2024
7 checks passed
@jhlegarreta jhlegarreta deleted the AddMiscStatusBadgesToREADME branch March 28, 2024 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants