Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add emc-related helper functions - images #77
base: master
Are you sure you want to change the base?
[ENH] Add emc-related helper functions - images #77
Changes from 1 commit
3bee02d
88a6e80
bb4cc79
1e9c015
e4ea798
e982d6f
3588947
1544a55
b6e917e
a888d73
d872094
eb43043
abf5186
25ecfc0
02f82ce
bb6c9a5
56213a0
5e64dfa
85a285a
b13d57b
7767498
947a5ca
7403652
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should contribute this to Nipype. Why don't we start a module of nibabel interfaces with these functions and also upstream https://github.com/poldracklab/niworkflows/blob/master/niworkflows/interfaces/nibabel.py ?
WDYT @effigies ?
I think the more interfaces with nibabel handling we have screened by Chris, the better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why the function exists. It doesn't seem to be being called. And written without unnecessary boilerplate, it's quite short:
If something this small seems worth upstreaming, sure, why not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this is a nice, general purpose function that could be used in a lot of scenarios. It is basically a pure python equivalent to
fslmerge
?@effigies -- this function is referenced here. We are in the process of incorporating a much larger WIP piecemeal, for which this is a critical helper function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're using it in a
Function
interface then you need to importnibabel
in the function body.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's included in a general import list, along with numpy and a few others, for all
Function
nodes in the relevant workflow. See: https://github.com/nipreps/dmriprep/pull/62/files#diff-2ae94ced15c1b8a730ecb0ebdd0f532eR692-R701There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I think having nibabel interfaces handy with NiPype would be super-useful for everyone and with the big plus of your eyeballs for the time you keep tabs on nibabel and nipype (hopefully long from my egoistic pov).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've kept these in this PR for now until nipreps/niworkflows#489 gets merged. Also, the doctests here are specific to dmriprep's fixtures so they will need to be tweaked for tests in niworkflows. @oesteban @effigies