ENH: Add number of volumes per *b*-value to QC report #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
changed the title
oesteban
approved these changes
Dec 10, 2020
| @@ -29,6 +29,7 @@ class _CheckGradientTableOutputSpec(TraitedSpec): | |||
| out_bvec = File(exists=True) | |||
| full_sphere = traits.Bool() | |||
| pole = traits.Tuple(traits.Float, traits.Float, traits.Float) | |||
| num_shells = traits.Dict() | |||
There was a problem hiding this comment.
Suggested change
| num_shells = traits.Dict() | |
| num_shells = traits.Int | |
| shells_dist = traits.Dict |
| @@ -81,6 +86,7 @@ def _run_interface(self, runtime): | |||
| pole = table.pole | |||
| self._results["pole"] = tuple(pole) | |||
| self._results["full_sphere"] = np.all(pole == 0.0) | |||
| self._results["num_shells"] = table.count_shells | |||
There was a problem hiding this comment.
Suggested change
| self._results["num_shells"] = table.count_shells | |
| self._results["num_shells"] = len(table.count_shells) | |
| self._results["shells_dist"] = table.count_shells |
Comment on lines
+62
to
+63
| >>> check.outputs.num_shells | ||
| {0: 12, 1200: 32, 2500: 61} |
There was a problem hiding this comment.
Suggested change
| >>> check.outputs.num_shells | |
| {0: 12, 1200: 32, 2500: 61} | |
| >>> check.outputs.num_shells | |
| 3 | |
| >>> check.outputs.shells_dist | |
| {0: 12, 1200: 32, 2500: 61} |
Comment on lines
+51
to
+52
| >>> check.outputs.num_shells | ||
| {0.0: 12, 1200.0: 32, 2500.0: 61} |
There was a problem hiding this comment.
Suggested change
| >>> check.outputs.num_shells | |
| {0.0: 12, 1200.0: 32, 2500.0: 61} | |
| >>> check.outputs.num_shells | |
| 3 | |
| >>> check.outputs.shells_dist | |
| {0.0: 12, 1200.0: 32, 2500.0: 61} |
|
@josephmje do you think we can push this in early next week? |
Yes! Will do. I'll also add the part to show it in the reportlet. I may need to create a new PR as I accidentally got rid of this branch. |
|
Closing this in favour of #150 due to the old commits belonging to a deleted branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.