fix CI and lint #278
Open
fix CI and lint #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d-chambers To make the NRL stuff work, you basically have to download a local copy of it to your computer. For the tests I mocked up a miniature version of the NRL with the bare minimum files to appease ObsPy (see tests/test_data/mini_nrl). It looks like the tests are failing because it’s unable to find one (maybe all?) of the files on the version installed in the CI. Looking at the files in master and your PR, though, the files are clearly there so I’m not sure what’s happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the CI, it also changes the linting to use ruff.