Pydantic v2 #269
Merged
Pydantic v2 #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 96.57% 96.60% +0.03%
==========================================
Files 44 44
Lines 4812 4797 -15
Branches 676 675 -1
==========================================
- Hits 4647 4634 -13
+ Misses 108 107 -1
+ Partials 57 56 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
A note on performance implications: On my Dell laptop it takes 59.5 seconds to run the test suite and on this branch it takes 61 seconds. Given non-determinism in the tests, its probably the same. At least there aren't any big performance digressions captured by the test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Pydantic V2. It also pins pydantic to < 3 so we don't have everything break again when that is released.
Also fixes the doc-build script, and slightly modifies the behavior of some station utilities related to fetching channel responses from info contained in a dataframe.