Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump devise from 4.2.0 to 4.8.0 #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot-preview[bot]
Copy link

Bumps devise from 4.2.0 to 4.8.0. This update includes security fixes.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

Devise Gem for Ruby confirmation token validation with a blank string Devise before 4.7.1 confirms accounts upon receiving a request with a blank confirmation_token, if a database record has a blank value in the confirmation_token column. However, there is no scenario within Devise itself in which such database records would exist.

Patched versions: >= 4.7.1 Unaffected versions: none

Sourced from The Ruby Advisory Database.

Devise Gem for Ruby Time-of-check Time-of-use race condition with lockable module Devise ruby gem before 4.6.0 when the lockable module is used is vulnerable to a time-of-check time-of-use (TOCTOU) race condition due to increment_failed_attempts within the Devise::Models::Lockable class not being concurrency safe.

Patched versions: >= 4.6.0 Unaffected versions: none

Changelog

Sourced from devise's changelog.

4.8.0 - 2021-04-29

  • enhancements

    • Devise now enables the upgrade of OmniAuth 2+. Previously Devise would raise an error if you'd try to upgrade. Please note that OmniAuth 2 is considered a security upgrade and recommended to everyone. You can read more about the details (and possible necessary changes to your app as part of the upgrade) in their release notes. Devise's OmniAuth Overview wiki was also updated to cover OmniAuth 2.0 requirements.
      • Note that the upgrade required Devise shared links that initiate the OmniAuth flow to be changed to method: :post, which is now a requirement for OmniAuth, part of the security improvement. If you have copied and customized the Devise shared links partial to your app, or if you have other links in your app that initiate the OmniAuth flow, they will have to be updated to use method: :post, or changed to use buttons (e.g. button_to) to work with OmniAuth 2. (if you're using links with method: :post, make sure your app has rails-ujs or jquery-ujs included in order for these links to work properly.)
      • As part of the OmniAuth 2.0 upgrade you might also need to add the omniauth-rails_csrf_protection gem to your app if you don't have it already. (and you don't want to roll your own code to verify requests.) Check the OmniAuth v2 release notes for more info.
    • Introduce Lockable#reset_failed_attempts! model method to reset failed attempts counter to 0 after the user signs in.
      • This logic existed inside the lockable warden hook and is triggered automatically after the user signs in. The new model method is an extraction to allow you to override it in the application to implement things like switching to a write database if you're using the new multi-DB infrastructure from Rails for example, similar to how it's already possible with Trackable#update_tracked_fields!.
    • Add support for Ruby 3.
    • Add support for Rails 6.1.
    • Move CI to GitHub Actions.
  • deprecations

    • Devise::Models::Authenticatable::BLACKLIST_FOR_SERIALIZATION is deprecated in favor of Devise::Models::Authenticatable::UNSAFE_ATTRIBUTES_FOR_SERIALIZATION (@​hanachin)

4.7.3 - 2020-09-20

  • bug fixes
    • Do not modify :except option given to #serializable_hash. (by @​dpep)
    • Fix thor deprecation when running the devise generator. (by @​deivid-rodriguez)
    • Fix hanging tests for streaming controllers using Devise. (by @​afn)

4.7.2 - 2020-06-10

  • enhancements

    • Increase default stretches to 12 (by @​sergey-alekseev)
    • Ruby 2.7 support (kwarg warnings removed)
  • bug fixes

    • Generate scoped views with proper scoped errors partial (by @​shobhitic)
    • Allow to set scoped already_authenticated error messages (by @​gurgelrenan)

4.7.1 - 2019-09-06

  • bug fixes
    • Fix an edge case where records with a blank confirmation_token could be confirmed (by @​tegon)
    • Fix typo inside update_needs_confirmation i18n key (by @​lslm)

4.7.0 - 2019-08-19

  • enhancements

    • Support Rails 6.0
    • Update CI to rails 6.0.0.beta3 (by @​tunnes)
    • refactor method name to be more consistent (by @​saiqulhaq)
    • Fix rails 6.0.rc1 email uniqueness validation deprecation warning (by @​Vasfed)
  • bug fixes

    • Add autocomplete="new-password" to password_confirmation fields (by @​ferrl)
    • Fix rails_51_and_up? method for Rails 6.rc1 (by @​igorkasyanchuk)

... (truncated)

Commits
  • 57d1a1d Release v4.8.0
  • 5d5636f Merge pull request #5369 from heartcombo/ca-lockable-reset-attempts
  • a3ae35e Create a model hook around the lockable warden hook to reset attempts
  • e8e0c27 Revert "Lock bundler to 2.2.9 instead of latest"
  • 429afcb Bundle update
  • ef9a2f4 Use minitest helpers to check if objects respond to certain methods
  • 0cd72a5 Merge pull request #5347 from heartcombo/ca-build
  • 1ba53dc Lock bundler to 2.2.9 instead of latest
  • faef12c Use the 6-0-stable version of Rails to fix issue with JSON responses
  • c82a381 Bundle update
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [devise](https://github.com/plataformatec/devise) from 4.2.0 to 4.8.0. **This update includes security fixes.**
- [Release notes](https://github.com/plataformatec/devise/releases)
- [Changelog](https://github.com/heartcombo/devise/blob/master/CHANGELOG.md)
- [Commits](heartcombo/devise@v4.2.0...v4.8.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability labels Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants