Fix DoubleProposalProofs
#2983
Open
Fix DoubleProposalProofs
#2983
+201
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrxi
commented
Oct 17, 2024
nibhar
requested changes
Oct 17, 2024
hrxi
force-pushed
the
hrxi/double_proposal_proof
branch
4 times, most recently
from
117207b
to
4f21297
Compare
nibhar
approved these changes
Oct 25, 2024
Comment on lines
334
to
335
| let hash1: Blake2bHash = proposal1.proposal.hash(); | ||
| let hash2: Blake2bHash = proposal2.proposal.hash(); |
There was a problem hiding this comment.
Maybe we should add an assert for the equal rounds here. Not strictly necessary but DoubleProposalProofs without matching rounds are invalid and should never be created.
Suggested change
| let hash1: Blake2bHash = proposal1.proposal.hash(); | |
| let hash2: Blake2bHash = proposal2.proposal.hash(); | |
| assert_eq!(proposal1.round, proposal2.round); | |
| let hash1: Blake2bHash = proposal1.proposal.hash(); | |
| let hash2: Blake2bHash = proposal2.proposal.hash(); |
There was a problem hiding this comment.
Not done for now because we currently don't do that for the creation of any equivocation proof structure. We could automatically call verify I guess and assert! that it verifies. But maybe we could also do that at the call sites?
They required data unrelated to the signed proposals. It now uses the same signing infrastructure by factoring it out to `TendermintProposal` in a common crate. Fixes #2981.
The round in the proposal message is the relevant one.
This means that two different `TendermintProposal`s with the same `MacroHeader` are now also considered a violation.
hrxi
force-pushed
the
hrxi/double_proposal_proof
branch
from
4f21297
to
d0055b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They required data unrelated to the signed proposals. It now uses the same signing infrastructure by factoring it out to
TendermintProposalin a common crate.Fixes #2981.