Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add pre-commit workflow, pre-commit hooks for opentofu, check-yaml, and check-json #66

Merged
merged 10 commits into from
Sep 23, 2024

Conversation

smokestacklightnin
Copy link
Contributor

@smokestacklightnin smokestacklightnin commented Sep 22, 2024

This PR adds pre-commit hooks for opentofu, check-yaml, and check-json as well as a GitHub Action to run the pre-commit hooks for every pull request.

tofu_tflint is now included, which requires developers to install tflint locally on their machines.

@smokestacklightnin smokestacklightnin changed the title [CI] Add pre-commit workflow and hooks for opentofu [CI] Add pre-commit workflow, pre-commit hooks for opentofu, and check-yaml Sep 22, 2024
@leej3
Copy link
Collaborator

leej3 commented Sep 23, 2024

Ok let's use tofu_tflint. Applying it on this one might cause issues on your WIP PR. Enable/apply on whatever PR that is most convenient.

@smokestacklightnin smokestacklightnin changed the title [CI] Add pre-commit workflow, pre-commit hooks for opentofu, and check-yaml [CI] Add pre-commit workflow, pre-commit hooks for opentofu, check-yaml, and check-json Sep 23, 2024
@leej3 leej3 self-requested a review September 23, 2024 19:57
Copy link
Collaborator

@leej3 leej3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@leej3 leej3 merged commit ec67327 into nimh-dsst:main Sep 23, 2024
1 check passed
@smokestacklightnin smokestacklightnin deleted the ci/pre-commit-hooks branch September 23, 2024 19:59
smokestacklightnin pushed a commit to smokestacklightnin/osm that referenced this pull request Sep 23, 2024
…-hooks

[CI] Add `pre-commit` workflow, pre-commit hooks for opentofu, check-yaml, and check-json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants