Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.1 Set up GitHub CI/CD to run tests automatically #22

Merged
merged 5 commits into from
Jun 20, 2024
Merged

6.1 Set up GitHub CI/CD to run tests automatically #22

merged 5 commits into from
Jun 20, 2024

Conversation

gitstart-nimhdsst
Copy link
Contributor

Add CI/CD script to run tests automatically

leej3
leej3 previously requested changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@leej3 leej3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the tox.ini file to contain:

[tox]
envlist = py38, py39, py310, lint, coverage

@gitstart-nimhdsst gitstart-nimhdsst marked this pull request as draft June 20, 2024 15:39
@gitstart-app gitstart-app bot marked this pull request as ready for review June 20, 2024 15:57
@gitstart-nimhdsst gitstart-nimhdsst dismissed leej3’s stale review June 20, 2024 16:23

Hi @leej3 we have fixed the issue, kindly review again. thank you

@gitstart-nimhdsst gitstart-nimhdsst requested a review from leej3 June 20, 2024 16:23
leej3
leej3 approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@leej3 leej3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@leej3 leej3 merged commit 12efffc into main Jun 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leej3 leej3 leej3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitstart-nimhdsst @leej3