Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate work for document #9

Merged
merged 35 commits into from
Nov 25, 2024
Merged

Generate work for document #9

merged 35 commits into from
Nov 25, 2024

Conversation

quang-ng
Copy link
Collaborator

Context

Enhancements to PDF Upload Process

  • Refactored upload_pdfs.py: Improved the efficiency and readability of the PDF upload logic.
  • Updated run_upload_pdf_to_s3.py: Streamlined the script execution for uploading PDFs to S3.

leej3
leej3 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@leej3 leej3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great. Some small nitpicks

.github/workflows/tests.yml Show resolved Hide resolved
dsst_etl/_utils.py Outdated Show resolved Hide resolved
dsst_etl/upload_pdfs.py Outdated Show resolved Hide resolved
dsst_etl/upload_pdfs.py Outdated Show resolved Hide resolved
@joshlawrimore joshlawrimore merged commit 0ab28e0 into main Nov 25, 2024
4 checks passed
@leej3 leej3 deleted the add-work-in-doc branch December 23, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlawrimore joshlawrimore joshlawrimore left review comments

@leej3 leej3 leej3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quang-ng @leej3 @joshlawrimore