OddpubMetrics Docker image and Database Table Generation #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per for PDF processing
…proved data handling
…a wrapper for the ODDPub API.
…hout mock API, ensuring correct data retrieval from the database.
leej3
requested changes
Dec 18, 2024
.docker/postgres-compose.yaml
Outdated
| @@ -13,5 +13,13 @@ services: | |||
| timeout: 5s # Added missing timeout value | |||
| retries: 5 | |||
|
|
|||
| oddpub-dsst: | |||
There was a problem hiding this comment.
if we add all the services to this file then we should move it to the root directory and rename it to compose.yaml.
We could also launch the container using python-on-whales, or add separate compose files to this directory.
| oddpub_metrics.work_id = self.work_id | ||
| oddpub_metrics.document_id = self.document_id | ||
| self.db_session.add(oddpub_metrics) | ||
| self.db_session.commit() |
There was a problem hiding this comment.
Can you provide some output to the user here to confirm the tool has run correctly and perhaps show the results concisely
There was a problem hiding this comment.
also, perhaps we should get user confirmation before uploading/updating the database and have a -y flag for those who are sure they want to upload?
| # self.session.rollback() | ||
|
|
||
| # Check if the Works table exists before attempting to update or delete | ||
| inspector = inspect(self.engine) |
There was a problem hiding this comment.
why are we deleting here instead of rolling back?
…xamples for Oddpub service
… ensuring a cleaner setup process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on issue #14