made a carousel #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathrynowy
suggested changes
Jan 2, 2023
index.html
Outdated
| <title>Carousel</title> | ||
| </head> | ||
| <body> | ||
| <img class="arcticmonkeys" src="./img/photo1.jpg" alt="Alex"> |
There was a problem hiding this comment.
Create with a loop
what if I want you to add 10000 images to the carousel?
index.js
Outdated
|
|
||
| let index = 0; | ||
|
|
||
| function clickLeft() {} |
index.js
Outdated
| clickL.addEventListener( | ||
| "click", | ||
| (clickLeft = () => { | ||
| if (index === 0) { |
index.js
Outdated
| index--; | ||
|
|
||
| elems[index].style.display = "block"; | ||
| point[index].style.background = "Burlywood"; |
index.js
Outdated
| clickR.addEventListener( | ||
| "click", | ||
| (clickRight = () => { | ||
| if (index >= elems.length - 1) { |
kathrynowy
suggested changes
Feb 20, 2023
| } | ||
|
|
||
| .btn-left:hover { | ||
| background-color: white; |
There was a problem hiding this comment.
At first, we don’t use colors like this
only hex
And you should add variables
| .btn-right { | ||
| position: absolute; | ||
| top: 48%; | ||
| right: 31%; |
| <input id="clickR" type="button" value=" " class="btn-right"> | ||
|
|
||
| <div id="main"> | ||
| <div class="point"></div> |
| @@ -0,0 +1,86 @@ | |||
| const images = [ | |||
| "./img/photo1.jpg", | |||
There was a problem hiding this comment.
Create a dynamic array and use indexes
What if you have 100000 images?
|
|
||
| const point = document.getElementsByClassName("point"); | ||
|
|
||
| elems[0].style.display = "block"; |
There was a problem hiding this comment.
Can u do it while creative the element?
| point[0].style.background = "Burlywood"; | ||
|
|
||
| function createButtons() { | ||
| const clickL = document.getElementById("clickL"); |
|
|
||
| let index = 0; | ||
|
|
||
| function addChangeNone() { |
|
|
||
| clickL.addEventListener( | ||
| "click", | ||
| (clickLeft = () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.