Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog design #23

Merged
merged 7 commits into from
Sep 23, 2021
Merged

Blog design #23

merged 7 commits into from
Sep 23, 2021

Conversation

rafayet-monon
Copy link
Contributor

@rafayet-monon rafayet-monon commented Sep 22, 2021

This PR partially does some tickets -

And does the crud for comments

What happened

Design the blog with post and comments.

Insight

Downloaded a template and using it as a design. Create CRUD for comments.

The CSS is not perfect

Proof Of Work

Screen.Recording.2021-09-22.at.1.38.26.PM.mov

@rafayet-monon rafayet-monon self-assigned this Sep 22, 2021
@@ -0,0 +1,13 @@
<%= form_with model: [ @article, @article.comments.build ] do |form| %>
Copy link

@github-actions github-actions bot Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Replace instance variable with local variable

Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many little details like

  • nav bar not working on mobile
  • code indent
  • and copy/paste css

But it is perfeclty fine for the context and knowing that most of the views will be reworked into components ;-)

@junan junan merged commit d54bc1d into development Sep 23, 2021
@junan junan deleted the feature/blog-design branch September 23, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants