Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#541] Update the iOS template project structure to reflect the new modules #545

Merged
merged 1 commit into from
Dec 21, 2023
Merged

[#541] Update the iOS template project structure to reflect the new modules #545

merged 1 commit into from
Dec 21, 2023

Conversation

phongvhd93
Copy link
Contributor

What happened 👀

  • Update the file Standard-File-Organization.md
    • Update directory tree
    • Add new section Modules with new contents about Data and Domain modules

Insight 📝

Update the directory structure document to reflect the new changes on #349 - Modulization Data and Domain layer.

Proof Of Work 📹

Screenshot 2023-11-20 at 14 35 10
Screenshot 2023-11-20 at 14 35 16

@phongvhd93 phongvhd93 added this to the 4.10.0 milestone Nov 20, 2023
@phongvhd93 phongvhd93 self-assigned this Nov 20, 2023
@phongvhd93 phongvhd93 force-pushed the feature/#349-modular-data-and-domain branch from a732c17 to fcec223 Compare December 5, 2023 02:19
@phongvhd93 phongvhd93 force-pushed the feature/#541-update-doc-for-new-modules branch from a479abb to fa747ea Compare December 12, 2023 09:52
@phongvhd93 phongvhd93 requested a review from blyscuit December 12, 2023 09:53
@phongvhd93 phongvhd93 force-pushed the feature/#349-modular-data-and-domain branch from fcec223 to c86637e Compare December 15, 2023 07:09
Base automatically changed from feature/#349-modular-data-and-domain to develop December 21, 2023 02:32
blyscuit
blyscuit reviewed Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@blyscuit blyscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please rebase 🙏

@phongvhd93 phongvhd93 force-pushed the feature/#541-update-doc-for-new-modules branch from fa747ea to c9675af Compare December 21, 2023 02:36
@phongvhd93 phongvhd93 requested a review from blyscuit December 21, 2023 02:37
@blyscuit blyscuit added this pull request to the merge queue Dec 21, 2023
Merged via the queue into develop with commit 505ca73 Dec 21, 2023
4 checks passed
@blyscuit blyscuit deleted the feature/#541-update-doc-for-new-modules branch December 21, 2023 05:46
@blyscuit blyscuit mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgravity markgravity markgravity approved these changes

@blyscuit blyscuit blyscuit approved these changes

@suho suho Awaiting requested review from suho suho is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@nmint8m nmint8m Awaiting requested review from nmint8m nmint8m is a code owner

@vnntsu vnntsu Awaiting requested review from vnntsu vnntsu is a code owner

@ducbm051291 ducbm051291 Awaiting requested review from ducbm051291 ducbm051291 is a code owner

@Shayokh144 Shayokh144 Awaiting requested review from Shayokh144 Shayokh144 is a code owner

@Thieurom Thieurom Awaiting requested review from Thieurom Thieurom is a code owner

@nkhanh44 nkhanh44 Awaiting requested review from nkhanh44 nkhanh44 is a code owner

Assignees

@phongvhd93 phongvhd93

Labels
type : content
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@phongvhd93 @blyscuit @markgravity