[#349] Add the domain and data layers as targets (modules) in the project #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phongvhd93
requested review from
suho,
blyscuit,
markgravity,
minhnimble,
nmint8m,
vnntsu,
ducbm051291,
Shayokh144,
Thieurom and
nkhanh44
as code owners
phongvhd93
force-pushed
the
feature/#349-modular-data-and-domain
branch
2 times, most recently
from
c04be60 to
6d56662
Compare
blyscuit
reviewed
Oct 31, 2023
|
Great work 🤩 |
|
Small documentation would be great for the newly added modules 🙏 |
blyscuit
reviewed
Nov 1, 2023
phongvhd93
force-pushed
the
feature/#349-modular-data-and-domain
branch
from
6d56662 to
43846f7
Compare
I'm going to create another PR for updating document |
blyscuit
approved these changes
Nov 17, 2023
phongvhd93
force-pushed
the
feature/#349-modular-data-and-domain
branch
from
43846f7 to
41f9b85
Compare
suho
reviewed
Nov 20, 2023
vnntsu
reviewed
Nov 23, 2023
phongvhd93
force-pushed
the
feature/#349-modular-data-and-domain
branch
from
a732c17 to
fcec223
Compare
|
@vnntsu This looks ready to merge. Let me know if you are good with the new changes 🙏 |
phongvhd93
force-pushed
the
feature/#349-modular-data-and-domain
branch
from
fcec223 to
c86637e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
DataandDomainlayers to separate targets. And fix the issue that tests only run 2 app-level tests (UT and KIF)Insight 📝
Data,Domainand needed files toModulesfolder.buildAndTestlane, I've removed the configuration that only runs{ProjectName}Testsand{ProjectNameKIFTests}. Now, all the test targets will be executed if they are configured in schemes.Proof Of Work 📹
Kapture.2023-10-23.at.22.56.07.mp4