-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#505] Set up necessary library for a SwiftUI project #506
Conversation
f2c0200
to
f902844
Compare
de28d78
to
d0751d4
Compare
|
||
# Backend | ||
pod 'Alamofire' | ||
# Network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use either Backend
or Network
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solved in 232caf4
pod 'Alamofire' | ||
# Network | ||
pod 'Moya/Combine' | ||
pod 'JSONAPIMapper', :git => 'https://github.com/nimblehq/JSONMapper', :branch => 'main' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have tag, so please use tag instead of branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solved in 232caf4
@phongvhd93 Is it possible to dynamically change the content of the pod 'SnapKit'
pod 'RxAlamofire'
pod 'RxCocoa'
pod 'RxDataSources'
pod 'RxSwift'
pod 'RxNimble', subspecs: ['RxBlocking', 'RxTest'] Another simple solution is we'll default the # Uncomment these if you're using UIKit:
# pod 'SnapKit'
# pod 'RxSwift'
... |
We have 2 separate folders for SwiftUI and UIKit, and also 2 separate podfiles. With the current implementation, it is easier to change the content of the |
Oh, I missed this part 🙏 |
@@ -14,7 +14,8 @@ target '{PROJECT_NAME}' do | |||
pod 'Kingfisher' | |||
|
|||
# Backend | |||
pod 'Alamofire' | |||
pod 'Moya/Combine' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to close this issue #324 first, before adding Moya to other template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solved in 6346fc6
232caf4
to
6346fc6
Compare
What happened 👀
Update the profile of SwiftUI project by adding a new library or removing redundant 3rd-parties. For instance, we will add FlowStacks library, which handles the navigation flow in a SwiftUI application.
Insight 📝
Added the following libs:
Proof Of Work 📹
This PR must pass the CI