Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Moya as the main Network Layer #324

Open
blyscuit opened this issue Aug 19, 2022 · 1 comment
Open

Use Moya as the main Network Layer #324

blyscuit opened this issue Aug 19, 2022 · 1 comment
Assignees
@Shayokh144
Labels
type : feature

Comments

@blyscuit
Copy link
Collaborator

Why

Benefit

  • We can stop maintaining our network layer.
  • Every projects have the same network layer.
  • Knowledge transfer between projects.
  • Ease of onboarding because Moya is easier to read than Alamofire.

Acceptance Criteria

  • Add Moya to the project.
  • Remove redundant network layer code.

Resources

https://github.com/Moya/Moya/tree/master/docs
@blyscuit
Copy link
Collaborator Author

Please vote in the discussion

@markgravity markgravity modified the milestones: 3.9.0, 3.10.0 Aug 30, 2022
@Shayokh144 Shayokh144 self-assigned this Aug 30, 2022
@markgravity markgravity modified the milestones: 3.10.0, 3.11.0 Sep 28, 2022
@vnntsu vnntsu modified the milestones: 3.11.0, 3.12.0 Nov 7, 2022
@Shayokh144 Shayokh144 modified the milestone: 3.12.0 Nov 23, 2022
@Shayokh144 Shayokh144 mentioned this issue Nov 28, 2022
Closed
@Shayokh144 Shayokh144 linked a pull request Nov 28, 2022 that will close this issue
[#324] Use Moya as the main Network Layer #394
Closed
@suho suho changed the title [RFC] Use Moya as the main Network Layer Use Moya as the main Network Layer Nov 29, 2022
@vnntsu vnntsu modified the milestones: 3.12.0, 3.13.0 Nov 30, 2022
@vnntsu vnntsu modified the milestones: 4.0.0, 4.1.0 Jan 3, 2023
@vnntsu vnntsu modified the milestones: 4.1.0, 4.2.0 Jan 31, 2023
@vnntsu vnntsu modified the milestones: 4.2.0, 4.3.0 Feb 28, 2023
@vnntsu vnntsu modified the milestones: 4.3.0, 4.4.0 Mar 31, 2023
@vnntsu vnntsu removed this from the 4.4.0 milestone May 8, 2023
@suho suho mentioned this issue Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shayokh144 Shayokh144

Labels
type : feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#324] Use Moya as the main Network Layer nimblehq/ios-templates
4 participants
@blyscuit @Shayokh144 @vnntsu @markgravity