Skip to content

Commit

Permalink
Merge pull request #232 from nimblehq/chore/209-clear-xcode-warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
suho authored Nov 25, 2021
2 parents a75c93e + df0e3ef commit ce84919
Show file tree
Hide file tree
Showing 12 changed files with 17 additions and 12 deletions.
1 change: 1 addition & 0 deletions .swift-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
5.0
1 change: 1 addition & 0 deletions .swiftformat
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@
--disable wrapMultilineStatementBraces
--disable wrapSwitchCases
--disable blankLinesAtStartOfScope
--stripunusedargs closure-only
1 change: 1 addition & 0 deletions Podfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
platform :ios, '11.0'
use_frameworks!
inhibit_all_warnings!

def testing_pods
pod 'Quick'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@ extension TargetAction {
return .pre(
script: "\"\(rswiftPath)\" generate \"\(outputPath)\"",
name: "R.swift",
inputPaths: ["\(inputPath)"],
outputPaths: ["\(outputPath)"],
basedOnDependencyAnalysis: true
basedOnDependencyAnalysis: false
)
}

Expand Down Expand Up @@ -78,7 +77,7 @@ extension TargetAction {
;;
esac
"""

return .post(
script: script,
name: "Copy GoogleService-Info.plist",
Expand Down
2 changes: 1 addition & 1 deletion {PROJECT_NAME}/Sources/Constants/Constants+API.swift
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
// Constants+API.swift
//

extension Constants.API { }
extension Constants.API {}
2 changes: 1 addition & 1 deletion {PROJECT_NAME}/Sources/Constants/Constants.swift
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@

enum Constants {

enum API { }
enum API {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
// NetworkAPIProtocol.swift
//

import RxSwift
import Alamofire
import RxAlamofire
import RxSwift

protocol NetworkAPIProtocol {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// RequestConfiguration.swift
//

import Foundation
import Alamofire
import Foundation

protocol RequestConfiguration {

Expand Down
2 changes: 1 addition & 1 deletion {PROJECT_NAME}/Sources/Data/NetworkAPI/NetworkAPI.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// NetworkAPI.swift
//

import Foundation
import Alamofire
import Foundation
import RxSwift

final class NetworkAPI: NetworkAPIProtocol {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
// UseCaseFactoryProtocol.swift
//

protocol UseCaseFactoryProtocol: AnyObject { }
protocol UseCaseFactoryProtocol: AnyObject {}
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ extension Navigator {

enum Scene {
// Define scene
case home
}
}
8 changes: 5 additions & 3 deletions {PROJECT_NAME}/Sources/Presentation/Navigator/Navigator.swift
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,18 @@ protocol Navigatable: AnyObject {
final class Navigator {

private func viewController(from scene: Scene) -> UIViewController {
#warning("Create view controllers here")
return HomeViewController()
switch scene {
case .home:
return HomeViewController()
}
}
}

extension Navigator: Navigatable {

func show(scene: Scene, sender: UIViewController?, transition: Transition) {
let target = viewController(from: scene)
if case .root(let window) = transition {
if case let .root(window) = transition {
let snapshotOverlayView = UIScreen.main.snapshotView(afterScreenUpdates: false)
target.view.addSubview(snapshotOverlayView)
window?.rootViewController = target
Expand Down

0 comments on commit ce84919

Please sign in to comment.