Skip to content

Commit

Permalink
[97] Update post-actions for build configurations
Browse files Browse the repository at this point in the history
  • Loading branch information
nmint8m committed Oct 22, 2020
1 parent d33e3b1 commit 48464a2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 0 additions & 2 deletions Nimble Templates/App.xctemplate/TemplateInfo.plist
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,6 @@
<string>___PACKAGENAME___</string>
<key>SharedSettings</key>
<dict>
<!-- <key>PRODUCT_NAME</key>
<string>$(TARGET_NAME)</string> -->
<key>SWIFT_VERSION</key>
<string>5.0</string>
</dict>
Expand Down
8 changes: 5 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,20 +42,22 @@ Because you will not use the default configutations (`Debug` and `Release`) any

<img src="./images/readme/configuration_result.png" width="500">

One more thing there are some duplicated build settings which is store in the file `project.pbxproj`. Some of them are automaticcally initialized and some are customized. For an instance, the build settings `PRODUCT_BUNDLE_IDENTIFIER` for `Dev Staging` are duplicated.
One more thing there are some duplicated build settings stored in the file `project.pbxproj`. Some of them are automatically initialized and some are customized. For an instance, the build setting `PRODUCT_BUNDLE_IDENTIFIER` for `Dev Staging` is duplicated.

| Default | Custom |
|---|---|
| <img src="./images/readme/configuration_default-attributes.png" width="400"> | <img src="./images/readme/configuration_custom-attributes.png" width="400"> |

What we should do is to remove all duplicated settings for all build configuration. This is the list of settings that you should remove fron the default initializing:
What we should do is to remove all duplicated settings for all build configurations.

The following list is the default initialized settings that you should remove:

- `PRODUCT_BUNDLE_IDENTIFIER`
- `PRODUCT_NAME`

> Note:
>
> - Check the `Debug`/`Release` build configurations are completely remove out of the file `project.pbxproj
> - Check the `Debug`/`Release` build configurations are completely remove out of the file `project.pbxproj`
### Schemes

Expand Down

0 comments on commit 48464a2

Please sign in to comment.