Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency issue #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spenceralbrecht
Copy link

Add mainModel to dependency array for useEffect(). This is a fix for the issue I commented on here #2 (comment).

Add mainModel to dependency array for useEffect()
@nilooy
Copy link
Owner

nilooy commented May 5, 2022

Thanks for taking your time for the fix.
I was wondering if we should add the dependency, it's a normal warning comes with react, but does it stop the build process?

@spenceralbrecht
Copy link
Author

It still builds but it seems like other people aren't aware of this and have thought that the build is completely broken like #2 (comment). Also the dependency is added already in other parts of the code, see below

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants