Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for lch css #3174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support for lch css #3174

wants to merge 2 commits into from

Conversation

fbsanchez
Copy link

Notes:

npm tests passing
npm run format makes no changes

Summary

This PR fixes/implements the following bugs/features

  • Feature: Added support to lch css function at color/parser

Our project uses css lch function to calculate background colours. in order to get screenshots of the components wich are using lch function we needed to add this functionality

Test plan (required)

Demonstrate how the issue/feature can be replicated. For most cases, simply adding an appropriate html/css template into the reftests should be sufficient. Please see other tests there for reference.

Use following styles in examples/existing_canvas.html, ensure the html2canvas works.

    <style>
        canvas {
            border: 1px solid black;
        }
        button {
            clear: both;
            display: block;
        }
        #content {
            background: lch(76.5 4.24 49.5);
            padding: 50px 10px;
        }
    </style>

before PR:

image

after PR:
image

Please make sure that code adheres to the project code formatting. Running npm run format will automatically format your code correctly. done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant