Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
npm tests passing
npm run format makes no changes
Summary
This PR fixes/implements the following bugs/features
Our project uses css lch function to calculate background colours. in order to get screenshots of the components wich are using lch function we needed to add this functionality
Test plan (required)
Demonstrate how the issue/feature can be replicated. For most cases, simply adding an appropriate html/css template into the reftests should be sufficient. Please see other tests there for reference.
Use following styles in examples/existing_canvas.html, ensure the html2canvas works.
before PR:
after PR:
Please make sure that code adheres to the project code formatting. Running
npm run format
will automatically format your code correctly. done