Azure Pipelines: upgrade from macOS 10.13 -> 10.14 #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
(it may also be worth updating to macOS 10.15 here, since that should now be available and could future-proof the builds for a longer duration) |
This comment has been minimized.
This comment has been minimized.
This reverts commit a419258.
This comment has been minimized.
This comment has been minimized.
2 tasks
jayaddison
commented
Apr 14, 2020
|
karma-runner/karma-safari-launcher#22 seems like it would be a nice-to-have. I don't know for certain yet whether this would resolve the Safari launch issues for Safari Stable builds, but I have a sense that it would be a good idea either way. |
|
✔️ macOS tests are passing again and this pull request should be ready for review |
|
Thanks a lot for figuring out the CI issues! |
oliveira-gust
pushed a commit
to oliveira-gust/html2canvas
that referenced
this pull request
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As per a recent Microsoft's Azure DevOps blog post, build images for
macOS 10.13now appear to have been removed from Azure Pipelines.This is causing macOS-related builds to fail.
This pull requests updates the base image for those builds to the more recent
macOS-10.14.Test plan (required)
The result of Azure Pipeline builds on this pull request for macOS-derived test suites should indicate whether the change is successful.
Note that this pull request does not include the build fixes made in #2203 pull request that addresses failures for Chrome on Linux.