-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sleep after every download #50
base: master
Are you sure you want to change the base?
Conversation
can you provide a rationale for this change? what effect are we trying to avoid here? |
In short I'm trying to avoid return code 1 when doing |
@mariuszskon sure but why does sleeping help? I'd understand if you would introduce some kind of retry mechanism with a back-off, but 100ms seems like some magic value |
I'm not 100% sure but I believe the sleep return code is used which leads to 0. |
To clarify, I don't think this is a great solution either, but I saw the |
I don't think that's accurate. So it's not an obvious fix for me. will have to look at the actual error case. |
Do we even have a consistent exit code set for the downloads? I mean, there has been an error, so a non-null exit code would be fine - but we've ignored that error and continued downloading other packages. Maybe just adding an |
This is ensures we consistently perform a sleep regardless what categories we download.
Naively fixes #49.