Lateral spreading revision #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the expansion description within the redback_afterglow model from exponential, to quasi-(Granot-Piran 2012). The original sound-speed approximation was an absolute upper-limit and overestimates spreading compared to hydro-simulations.
A better way to approximate expansion -- acts like Granot & Piran 2012 and not the exponential sound speed
GPLamb
commented
Nov 5, 2024
| fac = 0.5 * latstep | ||
| OmG = rotstep * (np.cos(thi - fac) - np.cos(ex + thi + fac)) # equivalent form for linear spacing | ||
| OmG = rotstep * (np.cos(thi - fac) - np.cos(ex/self.res + thi + fac)) # equivalent form for linear spacing | ||
| else: | ||
| te = np.ones(te.size) # no expansion |
There was a problem hiding this comment.
This should be ex = np.ones(te.size)
|
|
|
Thanks @GPLamb, is this ready to go or are you still working on it? I need to fix a few things on other pull requests before I can merge this in. |
|
This should be good to - I've run extra checks against JetSimpy and PyBlastAftefglowMag and it's spot on |
|
Nice one |
|
|
|
[like] Lamb, Gavin reacted to your message:
…________________________________
From: Nikhil Sarin ***@***.***>
Sent: Wednesday, November 13, 2024 9:35:30 AM
To: nikhil-sarin/redback ***@***.***>
Cc: Lamb, Gavin ***@***.***>; Mention ***@***.***>
Subject: Re: [nikhil-sarin/redback] Lateral spreading revision (PR #243)
Merged #243<https://urldefense.com/v3/__https://github.com/nikhil-sarin/redback/pull/243__;!!IhKztkE!aoLrP1O92FRIqFP9YvyuqQq-KncVoPtyW9OKjWCvBovTPDAoztvT9G3zto-rnGtshSc0bNRH5uZJ2TOAnyRydbAMVK9D$> into master.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/nikhil-sarin/redback/pull/243*event-15279562758__;Iw!!IhKztkE!aoLrP1O92FRIqFP9YvyuqQq-KncVoPtyW9OKjWCvBovTPDAoztvT9G3zto-rnGtshSc0bNRH5uZJ2TOAnyRydUCMeIM6$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A5QJS4Q5RZI63SNWE46MSVT2AMMOFAVCNFSM6AAAAABRHJSSOGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGI3TSNJWGI3TKOA__;!!IhKztkE!aoLrP1O92FRIqFP9YvyuqQq-KncVoPtyW9OKjWCvBovTPDAoztvT9G3zto-rnGtshSc0bNRH5uZJ2TOAnyRydeU1532P$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
________________________________
Important Notice: Liverpool John Moores University was established as a Higher Education Corporation under section 121 of the Education Reform Act 1988. Further information about Liverpool John Moores University can be found at https://www.ljmu.ac.uk/about-us The information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent and the recipient must ensure that the email (and attachments) are virus free. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. We will use the personal data information provided by you to respond to your email. For information about how we process personal data and monitor communications please see our Privacy Notice. https://www.ljmu.ac.uk/legal/privacy-and-cookies
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the spreading description in my fork. From pure sound-speed (exponential) to something more ~Granot & Piran 2012
Allows better comparison with hydro results