do not convert RGB/BGR inplace on imencode/imwrite

nihui · Aug 8, 2023 · 4327ab2 · 4327ab2
1 parent 49039eb
commit 4327ab2
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/highgui/src/highgui.cpp b/highgui/src/highgui.cpp
@@ -201,12 +201,16 @@ bool imwrite(const String& filename, InputArray _img, const std::vector<int>& pa
  else if (img.type() == CV_8UC3)
  {
  c = 3;
- cvtColor(img, img, COLOR_BGR2RGB);
+ Mat img2
+ cvtColor(img, img2, COLOR_BGR2RGB);
+ img = img2;
  }
  else if (img.type() == CV_8UC4)
  {
  c = 4;
- cvtColor(img, img, COLOR_BGRA2RGBA);
+ Mat img2
+ cvtColor(img, img2, COLOR_BGRA2RGBA);
+ img = img2;
  }
  else
  {
@@ -368,12 +372,16 @@ bool imencode(const String& ext, InputArray _img, std::vector<uchar>& buf, const
  else if (img.type() == CV_8UC3)
  {
  c = 3;
- cvtColor(img, img, COLOR_BGR2RGB);
+ Mat img2;
+ cvtColor(img, img2, COLOR_BGR2RGB);
+ img = img2;
  }
  else if (img.type() == CV_8UC4)
  {
  c = 4;
- cvtColor(img, img, COLOR_BGRA2RGBA);
+ Mat img2;
+ cvtColor(img, img2, COLOR_BGRA2RGBA);
+ img = img2;
  }
  else
  {