Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts - refactoring and add new functionalities #177

Draft
wants to merge 35 commits into
base: dev
Choose a base branch
from

Commits on May 13, 2024

  1. Shortcuts - refactoring and add new functionalities

    Refactoring the shortcuts with adding :
    - same organisation of files
    - remove junk code
    - add internationalization of shortcuts
    - add AddCarbs shortcuts
    - add createAndApply temp target
    - Add override preset selection, application and cancelation
    - Add Carbs preset list and display all carbs, fat and proteins associated
    - fix carb list shortcut issue
    - fix carb added with fat/protein  shortcut
    - add bolus shortcuts with guardrails
    - harmonise temporary target labels
    - add in OIAPS a shortcut config allowing to authorize bolus enact and guardrails.
    - Add localisation for the UI shortcuts config view and shortcuts
    - minor improvements to avoid warning in build
    avouspierre committed May 13, 2024
    Configuration menu
    Copy the full SHA
    aa8ae7b View commit details
    Browse the repository at this point in the history
  2. TempTarget Shortcut fix for unit (by @robert)

    md/dL instead of mg/L
    for instead of during
    
    # Conflicts:
    #	FreeAPS/Sources/Localizations/ShortcutsDetail/ShortcutsDetail.xcstrings
    mountrcg authored and avouspierre committed May 13, 2024
    Configuration menu
    Copy the full SHA
    faa349d View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. update alive to dev

    MikePlante1 authored and avouspierre committed May 15, 2024
    Configuration menu
    Copy the full SHA
    7436329 View commit details
    Browse the repository at this point in the history
  2. update alive to dev (2)

    MikePlante1 authored and avouspierre committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1c01b11 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    35bd5d2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d74029d View commit details
    Browse the repository at this point in the history
  5. List Bolus short cut

    however the BolusIntent does not popup the amount dialog
    mountrcg authored and avouspierre committed May 15, 2024
    Configuration menu
    Copy the full SHA
    54a974c View commit details
    Browse the repository at this point in the history
  6. more text and reminder localization

    mountrcg authored and avouspierre committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8f9fbd0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f23836c View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Fix to prompt input for bolusQuantity

    • Mark bolusQuantity as non-optional
    • Remove associated guard/else {...} since this is not optional
    aug0211 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    961612b View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. Configuration menu
    Copy the full SHA
    7faf40d View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. fix: changes from pr are addressed

    Signed-off-by: Sjoerd-Bo3 <[email protected]>
    Sjoerd-Bo3 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    fc3fa19 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23d23f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. refactor: rename files

    Sjoerd-Bo3 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    3dfed12 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8dcd89a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f574b66 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    18853be View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    55a2b94 View commit details
    Browse the repository at this point in the history
  6. revert change on package.resolved

    Signed-off-by: Sjoerd-Bo3 <[email protected]>
    Sjoerd-Bo3 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    34adc91 View commit details
    Browse the repository at this point in the history
  7. fix: gracefully unwrapping of id

    Signed-off-by: Sjoerd-Bo3 <[email protected]>
    Sjoerd-Bo3 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    9b60001 View commit details
    Browse the repository at this point in the history
  8. refactor: parameterizing function

    Signed-off-by: Sjoerd-Bo3 <[email protected]>
    Sjoerd-Bo3 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    fe41399 View commit details
    Browse the repository at this point in the history
  9. fix: default glucosestring

    Signed-off-by: Sjoerd-Bo3 <[email protected]>
    Sjoerd-Bo3 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ac92afb View commit details
    Browse the repository at this point in the history
  10. refactor: remove postfix underscore - unneccesary

    Signed-off-by: Sjoerd-Bo3 <[email protected]>
    Sjoerd-Bo3 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    0b972b6 View commit details
    Browse the repository at this point in the history
  11. additional strigns for translation

    Signed-off-by: Sjoerd-Bo3 <[email protected]>
    Sjoerd-Bo3 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    911d564 View commit details
    Browse the repository at this point in the history
  12. refactor: removed spaces

    Signed-off-by: Sjoerd-Bo3 <[email protected]>
    Sjoerd-Bo3 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4065a4c View commit details
    Browse the repository at this point in the history
  13. refactor: rename noAllowed case to notAllowed

    Signed-off-by: Sjoerd-Bo3 <[email protected]>
    Sjoerd-Bo3 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    60d36ea View commit details
    Browse the repository at this point in the history
  14. refactor: rename bolusQ to BolusQuantity

    Signed-off-by: Sjoerd-Bo3 <[email protected]>
    Sjoerd-Bo3 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    d0da3f3 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2024

  1. updates all localizations shortcuts

    updates all localizations shortcuts
    avouspierre committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    bdf7779 View commit details
    Browse the repository at this point in the history
  2. fix issue in unit for temptarget

    fix issue for the shortcut create a temp target” where the unit should be stored only in mgdL
    avouspierre committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    b843728 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Configuration menu
    Copy the full SHA
    85e32c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Configuration menu
    Copy the full SHA
    d5f13b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Fix shortcut override confirmation text

    - Shortcut cancellation confirmation text should display the latest override, not the first override
    - Addresses a text display bug identified by Mike here: nightscout#177 (comment)
    aug0211 committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    f72f9cb View commit details
    Browse the repository at this point in the history
  2. Cleanup carb/fat/protein entry via shortcut

    - Error handling for carb/fat/protein exceeding max defined
    - Show user all values for carb/fat/protein entered in the confirmation
    - Do not assume 0 for these values, instead - ask the user
    - This can be refactored later if we can get access to settingsManager.settings.maxCarbs/Fat/Protein: if we get that, drop it into the upper bound in the shortcut and clean up other code
    - Lastly, we should allow the user to specify the date if they'd like to, in the future
    aug0211 committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    f5915f5 View commit details
    Browse the repository at this point in the history
  3. Fix shortcut bolus safety guards

    - Block (with an alert) boluses that exceed the user-configured max (whether this is max pump max bolus or recommended amount)
    - Addresses this request nightscout#177 (comment)
    aug0211 committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    6ce9fbe View commit details
    Browse the repository at this point in the history
  4. Phrasing updates for shortcuts

    - Addresses requested updates in PR feedback for phrasing
    - See original requests here: nightscout#177 (comment)
    - Skipped one request based on my judgment
    - This commit includes comment cleanup on shortcut guardrails, too
    - No functional change in this commit
    aug0211 committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    90d62d2 View commit details
    Browse the repository at this point in the history