Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the active sensors to the sensor attributes #1045

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add the active sensors to the sensor attributes #1045

wants to merge 2 commits into from

Conversation

apocaliss92
Copy link

No description provided.

@nielsfaber
Copy link
Owner

Thanks for your PR.
Since the discussion about the change is still ongoing, I will not merge this yet.
Hope you can participate in the discussion so we can work towards the final implementation.

RomainGehrig
RomainGehrig reviewed Oct 27, 2024
View reviewed changes
custom_components/alarmo/alarm_control_panel.py
@@ -504,6 +508,8 @@ async def async_added_to_hass(self):
self.open_sensors = state.attributes["open_sensors"]
if "bypassed_sensors" in state.attributes:
self._bypassed_sensors = state.attributes["bypassed_sensors"]
if "actve_sensors" in state.attributes:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo that'll come back to bite you ;) (just passing by)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainGehrig RomainGehrig RomainGehrig left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apocaliss92 @nielsfaber @RomainGehrig