🚨 Fix Clippy error use_or_insert_with
#150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicokosi
changed the title
use_or_insert_with
Fixes CI failing with commit 6db5049: error: use of `or_insert_with` to construct default value Error: --> src/lib.rs:115:18 | 115 | .or_insert_with(Vec::new)) | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `-D clippy::unwrap-or-default` implied by `-D warnings` https://github.com/nicokosi/pullpito/actions/runs/6887187730/job/18733990115 Seems related to Cargo 1.73 update. I had to uninstall Hombrew-installed Rust to reproduce locally: brew rm rust # Cargo 1.72.1
nicokosi
force-pushed
the
fix_CI_due_to_Clippy_error_use_or_insert_with
branch
from
86b7c54
to
0c4e29f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI failing with commit 6db5049:
https://github.com/nicokosi/pullpito/actions/runs/6887187730/job/18733990115
Seems related to Cargo 1.73 update.
I had to uninstall Hombrew-installed Rust to reproduce locally: