Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Supabase as Auth Provider + Prettier format for the generated files #137

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

OmegaHawkeye
Copy link

@OmegaHawkeye OmegaHawkeye commented Feb 15, 2024

This PR adds 2 things:

  1. Supabase as a new Auth Provider
  2. Either reads the users prettier config file or generates a default prettier config file and also formats the generated files based on the prettier config.

I had to convert many functions to async ones but it still works as far as I tested ( add and generate command still work ).

Would close this issue: #49.

Btw to get RLS with Supabase and Drizzle generally I think we have to use auth.uid()::text in the RLS editor. It worked like that then but not without.

Result:
kirimase_supabase_marked

@OmegaHawkeye OmegaHawkeye marked this pull request as draft February 16, 2024 13:16
@nicoalbanese
Copy link
Owner

Such a great idea re prettier!

@OmegaHawkeye OmegaHawkeye marked this pull request as ready for review February 21, 2024 16:22
@OmegaHawkeye OmegaHawkeye marked this pull request as draft February 21, 2024 16:22
@OmegaHawkeye OmegaHawkeye marked this pull request as ready for review February 21, 2024 17:01
@OmegaHawkeye
Copy link
Author

This should now work as expected with Supabase as an Auth Provider and prettier for formatting. I also added zod-form-data as form validation library for the server actions for supabase auth.

@OmegaHawkeye
Copy link
Author

PR branch is up to date with this master branch and also includes changes for #145. Would be ready for merge.

@OmegaHawkeye
Copy link
Author

@nicoalbanese Just curious as to why this pr isn't getting merged after being ready and up to date for 2 weeks or so already?

@trevorpfiz
Copy link

@OmegaHawkeye thank you for this, really looking forward to using it!

@OmegaHawkeye OmegaHawkeye deleted the branch nicoalbanese:master April 26, 2024 23:19
@OmegaHawkeye OmegaHawkeye deleted the master branch April 26, 2024 23:19
@OmegaHawkeye OmegaHawkeye restored the master branch April 26, 2024 23:20
@OmegaHawkeye OmegaHawkeye reopened this Apr 26, 2024
@thecmdrunner
Copy link

Any movement on this? Supabase seems like a really good addition!

@adityamiskin
Copy link

When is it going to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants