Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI checks on pull requests to main #275

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

uncenter
Copy link
Contributor

@uncenter uncenter commented Dec 10, 2024

Closes #273. Check failure is fixed by #272.

@nickgerace
Copy link
Owner

@uncenter you likely need to rebase and force push

@nickgerace
Copy link
Owner

nickgerace commented Dec 10, 2024

By the way @uncenter, random thought while I'm here, you should join the SI Discord or at least check out the repo. Lot of Rust code to play around with there and it's where I spend the vast majority of my programming time at present.

@uncenter
Copy link
Contributor Author

@uncenter you likely need to rebase and force push

Are there conflicts? GitHub isn't alerting me of any afaik.

@nickgerace
Copy link
Owner

@uncenter none, but you likely need to rebase to get the newest .github workflows

@uncenter
Copy link
Contributor Author

To get the checks to pass here you mean? I don't think we need to wait for that since if it passes on main it passes here (the check failure only serves to show it is working and running on pull requests!). I can rebase anyway though.

@uncenter
Copy link
Contributor Author

By the way @uncenter, random thought while I'm here, you should join the SI Discord or at least check out the repo. Lot of Rust code to play around with there and it's where I spend the vast majority of my programming time at present.

Joined the Discord, thanks!

@nickgerace nickgerace merged commit 8398e61 into nickgerace:main Dec 10, 2024
1 check passed
@uncenter uncenter deleted the patch-1 branch December 10, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run CI on pushes to PRs
2 participants