Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump workflow versions #412

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

MaximilianAlgehed
Copy link
Collaborator

Trying to bring things up to date to make sure the issues we've seen in CI on #397 aren't due to old versions.

@MaximilianAlgehed
Copy link
Collaborator Author

@nick8325 here is something we need to discuss. The old ci system has stopped working due to random github actions deprecations. I've updated to the latest version of haskell-ci and bumped the ci script. However, a consequence of this is that we can no longer support ghc versions older than 8.0.2 in ci.

Should we make the decision to discontinue ghc 7 support?

@MaximilianAlgehed
Copy link
Collaborator Author

@UlfNorell thoughts on this?

@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-bump-workflow-versions branch 5 times, most recently from b698ea5 to 4982338 Compare July 10, 2024 10:39
@MaximilianAlgehed
Copy link
Collaborator Author

MaximilianAlgehed commented Jul 10, 2024

Current state of things here:

  1. We can support 7.10.3 since that's supported by setup-haskell
  2. We change to setup-haskell as that gives us more flexibility than depending on haskell-ci
  3. I've set up the workflow to run as a cronjob nightly so that we see CI breaking earlier than in a PR (which is what happened here)

@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-bump-workflow-versions branch from 461d820 to 2f26dd8 Compare July 10, 2024 11:06
Copy link
Collaborator

@UlfNorell UlfNorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nothing else this greatly simplifies the CI setup. It seems to me the question here isn't should we drop ghc-7 support, but rather getting CI to run at all. If we want to keep support for older versions that's something that can be figured out later.

@MaximilianAlgehed MaximilianAlgehed merged commit 8974216 into master Jul 24, 2024
52 checks passed
@MaximilianAlgehed MaximilianAlgehed deleted the PR-bump-workflow-versions branch July 24, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants