Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation warning about the instances for Arbitrary (Set a) and friends being over the abstract set #379

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Documentation warning about the instances for Arbitrary (Set a) and friends being over the abstract set #379

merged 4 commits into from
Apr 4, 2024

Conversation

MaximilianAlgehed
Copy link
Collaborator

@MaximilianAlgehed MaximilianAlgehed commented Mar 23, 2024 •
edited
Loading

Comments welcome

closes #354

@MaximilianAlgehed
Copy link
Collaborator Author

comments welcome from @treeowl and @phadej

@MaximilianAlgehed MaximilianAlgehed marked this pull request as draft March 23, 2024 12:03
@MaximilianAlgehed MaximilianAlgehed marked this pull request as ready for review April 3, 2024 10:17
@treeowl
Copy link
Contributor

treeowl commented Apr 3, 2024

I would say more about the consequences (i.e., who should worry about this). Basically, only people digging into Data.Set.Internal need to care.

@MaximilianAlgehed
Copy link
Collaborator Author

I would say more about the consequences (i.e., who should worry about this). Basically, only people digging into Data.Set.Internal need to care.

Good idea, thank you!

@MaximilianAlgehed MaximilianAlgehed merged commit a3db258 into master Apr 4, 2024
74 checks passed
@MaximilianAlgehed MaximilianAlgehed deleted the PR-document-Set-Map branch April 4, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlfNorell UlfNorell UlfNorell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need better containers instances
3 participants
@MaximilianAlgehed @treeowl @UlfNorell