Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish Version #725

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Spanish Version #725

wants to merge 1 commit into from

Conversation

BitOven
Copy link

@BitOven BitOven commented Nov 13, 2016

This is my version of your software, I translated some stuff using translate txt files but also changed the basics so this version is on ly good for spanish people, I'm afraid.

I think you can keep this branch like a spanish branch but I'm newbie in this of development so it's up to you. I just wanted to share with you, the original maker, my modifications to your code. I'm still working on some personal changes, I started using git too late and forking you even later so my commits are mmmm zero. Sorry for the inconveniences.

Thank you for all this, anyways.

@nicholasmr
Copy link
Owner

Thanks for the contribution.
However, I can't add your changes files because you, unfortunately, have hardcoded the spanish tranlations. Also, I'm pretty sure there already are spanish translation, if you enable it in the seetings files?
What other changes did you make?

@BitOven
Copy link
Author

BitOven commented Nov 13, 2016

Yes most of the page translates if you enables it but not all. I made some
changes into de lang/translation txt that you may want to check, cause some
I added some spanish translations.
I also made changes in inducements tryout module, adding a translation file
that can be also interesting for you maybe.

The rest of changes I'm afraid you're right, I hardcoded it.

Thank you again for your software.

El 13 nov. 2016 19:19, "nicholasmr" [email protected] escribió:

Thanks for the contribution.
However, I can't add your changes files because you, unfortunately, have
hardcoded the spanish tranlations. Also, I'm pretty sure there already are
spanish translation, if you enable it in the seetings files?
What other changes did you make?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#725 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUGdFiQe6FGgCxArEacYFSnsO8nl3VdKks5q91SqgaJpZM4KwwL9
.

@nicholasmr
Copy link
Owner

No problem!
I'm sure your additions/changes are useful for Spanish users :-). If you wish, you are welcome to branch it.

@BitOven
Copy link
Author

BitOven commented Nov 19, 2016

No, I think I will remake the translation changes from your actual version
(and not hardcoded), so you can just add the commit to the master if it's
right. I just need some time to do it haha.

In the other hand, I'm getting some alerts in my web from your error log
saying that the sql_connection method is deprecated. Do you know when it
will be a real problem? Should I try to fix it? I think it's as simple as
changing the method but I don't really know your code or php well so I
still don't dare to do it.

Thank you again, sir.

2016-11-13 20:39 GMT+01:00 nicholasmr [email protected]:

No problem!
I'm sure your additions/changes are useful for Spanish users :-). If you
wish, you are welcome to branch it.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#725 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUGdFus7d9dWJ1OzkPXwjzvixtsVnyG8ks5q92dwgaJpZM4KwwL9
.

@nicholasmr
Copy link
Owner

OK.

No, not sure what the reason is. It's not OBBLM at least. Try restarting you mysql server or update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants