Add new comfort region: Comfort Zone of the Building Bioclimatic Chart #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Based on Milne and Givoni 1979 & ASHRAE 55-2017. Centered on PMV for: - Summer conditions: air velocity = 0.20 m/s clothing level = 0.60 clo (light to moderate clothes) metabolic rate = 1.25 met (seated with light activity) mean radiant temperature = 26°C (warm) - Winter conditions: air velocity = 0.20 m/s clothing level = 1.20 clo (long clothes) metabolic rate = 1.25 met (seated with light activity) mean radiant temperature = 19°C (normal)
6nv
reviewed
Aug 8, 2024
| @@ -100,8 +100,8 @@ export const plugin = new PanelPlugin<PsyOptions>(PsyPanel).setPanelOptions((bui | |||
| }) | |||
| .addMultiSelect({ | |||
| path: 'regions', | |||
| name: 'ASHRAE Comfort Regions', | |||
There was a problem hiding this comment.
All the regions shown are developed by ASHRAE, but I think this is fine to remove, in case we include other standards.
|
Excellent PR! I have no idea why the CI is failing. I just ran it on one of my old commits, and it also broke there. I figure there might be some issue with Grafana's docker image. I just made a post in Grafana's user Slack channel, and I'll merge this as soon as I hear a reply. |
|
CI was fixed here: grafana/plugin-tools#1046 |
|
Update: Psychart v4.5.0 is waiting for review on Grafana.com. psychart.nicfv.com is already live with the new version! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Milne and Givoni 1979 & ASHRAE 55-2017
Centered on PMV for:
Summer conditions:
air velocity = 0.20 m/s
clothing level = 0.60 clo (light to moderate clothes)
metabolic rate = 1.25 met (seated with light activity)
mean radiant temperature = 26°C (warm)
Winter conditions:
air velocity = 0.20 m/s
clothing level = 1.20 clo (long clothes)
metabolic rate = 1.25 met (seated with light activity)
mean radiant temperature = 19°C (normal)