Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/21 validation update #22

Merged

Conversation

easingthemes
Copy link
Contributor

#21

@zeke
Copy link
Member

zeke commented Dec 24, 2018

Thanks! In response to this PR, I've set up semantic-release in #23 which will now automatically release merged PRs to GitHub and npm.

Because this change affects validation, I think we should consider it a breaking change.

Can you add a commit with BREAKING CHANGE in the body? Note that BODY technically means everything after the first line of the commit. See https://www.conventionalcommits.org/en/v1.0.0-beta.2/

If you're using bash, you can start a multi-line commit using a single-quote then write the rest of the message on the following lines:

git commit --allow-empty -m 'fix: do not require description

This is a BREAKING CHANGE'

PS I know this is a lot of song and dance. Good luck and let me know if you get stuck!

@zeke
Copy link
Member

zeke commented Dec 2, 2019

Hey @easingthemes -- sorry I let this fall through the cracks for nearly a year. Are you able to make the changes I requested above?

@feross feross merged commit d0b203a into nice-registry:master Mar 29, 2020
@feross
Copy link
Member

feross commented Mar 29, 2020

I was able to use the Squash and Merge feature on GitHub to edit the commit message as specified :)

@zeke
Copy link
Member

zeke commented Mar 29, 2020

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zeke zeke added the released label Mar 29, 2020
feross added a commit that referenced this pull request Mar 29, 2020
feross added a commit that referenced this pull request Mar 29, 2020
Fixes: #27

Related: #22

BREAKING CHANGE
feross added a commit that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants