Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(asset): change query types for assets #94

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

saradei-ni
Copy link
Collaborator

@saradei-ni saradei-ni commented Oct 18, 2024

Pull Request

🀨 Rationale

There are minor details that need to be changed in order to comply with the rest of the plugin structures

πŸ‘©β€πŸ’» Implementation

  • Changed queryType to type for all asset queries
  • Changed the composition model for the AssetQuery
  • Changed the layout of the filter and fields
image
  • Fix the path construction for the the Asset Datasource

πŸ§ͺ Testing

  • Unit tests
  • Manual testing

βœ… Checklist

@kkerezsi kkerezsi changed the title Users/alkerezs/change query types for assets feat(asset): change query types for assets Oct 18, 2024
@saradei-ni saradei-ni merged commit 184ebeb into main Oct 18, 2024
1 check passed
@saradei-ni saradei-ni deleted the users/alkerezs/change-query-types-for-assets branch October 18, 2024 10:20
mure pushed a commit that referenced this pull request Oct 18, 2024
## [3.33.0](v3.32.0...v3.33.0) (2024-10-18)

### Features

* **asset:** change query types for assets ([#94](#94)) ([184ebeb](184ebeb))
@mure
Copy link
Collaborator

mure commented Oct 18, 2024

πŸŽ‰ This PR is included in version 3.33.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@mure mure added the released label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants