FAST Project Re-alignment HLD #2476
Conversation
rajsite
changed the title
| - [Microsoft vscode webui toolkit](https://github.com/microsoft/vscode-webview-ui-toolkit/issues/561) (sunset due to FAST re-alignment) | ||
| - [National General](https://components.nationalgeneral.com/ui/?path=/story/components-design-system-provider--branding) (does not appear to be open source) | ||
|
|
||
| #### Platform alignment gaps of archive packages |
There was a problem hiding this comment.
If links to relevant issues / documentation are desired for specific items (or all items if really desired) in this section I can add them.
rajsite
requested review from
jattasNI,
atmgrifter00 and
mollykreis
as code owners
| - Bug fixes or generic changes could be in `fast`. | ||
| - Signficant new feature development may require forking from fast and adopting nimble patterns. | ||
| - Notify teams directly leveraging `@microsoft/fast-*` to switch to `@ni/fast-*` (scope not evaluated). | ||
| - Consider repatriating some changes back to FAST where a fork was made for minimal bug fixes (scope not evaluated). |
There was a problem hiding this comment.
Could you add the step of adopting the new packages in the Nimble repo and any sub-steps that we can think of? For example:
- update package.json and TypeScript imports to point to the new packages. Do we expect any other breaking changes or since we're forking from the same versions we currently depend on it should be a drop-in replacement?
- update READMEs/CONTRIBUTINGs that refer to FAST to link to the fork either in addition to or instead of the original
- any expected client impact if clients don't depend on FAST directly?
There was a problem hiding this comment.
Notes for me to add, azdo search for fast and codesearch. Looks like mostly Ozone, jupyter react wrapper, and I think stale TestInsights references.
|
|
||
| Work that should be done imminently (over the next 1-3 months). | ||
|
|
||
| - Fork the `microsoft/fast` repo to `ni/fast` as a new top-level GitHub repository. |
There was a problem hiding this comment.
Might mention that it'll be open source (I assume)
| /specs | ||
| ``` | ||
|
|
||
| - Update npm dependencies to latest. |
There was a problem hiding this comment.
Some other common repo things we should probably do:
- enable Renovate
- add CODEOWNERS (can happen after all the setup is done, but we want changes to be reviewed after that)
- update README to link back to the original repo and graciously acknowledge that we are standing on their shoulders
- ensure we are in compliance with their license and pick what license we will use for the fork
- update CONTRIBUTING to describe policies for beachball / owners (could be copied from Nimble or just link to Nimble's)
| - FAST has stated that they are [unwilling to accept](https://github.com/microsoft/fast/pull/6960#issuecomment-2344299634) future bug fix contributions in archive branches. Made an [exception for the memory leak bug](https://github.com/microsoft/fast/issues/7022#issuecomment-2344312698). | ||
| - Bulk closed [~200 GitHub issues](https://github.com/microsoft/fast/issues?q=is%3Aissue%20label%3Aclosed%3Aobsolete%20closed%3A%3E2024-05-01%20%20) (bugs, new features, etc.) related to archive packages. | ||
|
|
||
| #### Users of archive packages |
There was a problem hiding this comment.
This might be outside the scope of this HLD, but do you have thoughts on whether we'd encourage any community around this fork? Would we publicize it on FAST Discord? Welcome other projects to adopt it? Accept contributions from outside NI?
If it's an explicit non-goal we could mention it. If it's TBD I'm ok to leave it unaddressed or allude to it as possible future work.
Pull Request
🤨 Rationale
HLD for how Nimble will address the FAST project re-alignment.
See #2207
See microsoft/fast#6955
AzDo Work Item 2842865
✅ Checklist