Add missing label values for Angular and Blazor #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
requested review from
atmgrifter00,
msmithNI and
rajsite
as code owners
rajsite
approved these changes
Sep 5, 2024
|
Bypassing Blazor owners for straightforward change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
#1747 has a task to validate that label provider strings are synced across all frameworks. There was a new "Loading..." string that was missing for Angular and Blazor.
👩💻 Implementation
Scanned all the label provider code and tests across all frameworks and ensured parity.
🧪 Testing
PR build
✅ Checklist