Update icon metaphors and fix checkbox to use larger check icon #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredvisser
approved these changes
Jun 4, 2024
rajsite
reviewed
Jun 4, 2024
packages/nimble-components/src/icon-base/tests/icon-metadata.ts
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
Jun 4, 2024
jattasNI
approved these changes
Jun 4, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Some of the icon metaphors listed in our docs were incomplete or incorrect.
👩💻 Implementation
I ran my proposed changes by Brandon and he approved. He also happened to mention that we were using the wrong checkmark icon for our checkbox, so I fixed that, too.
🧪 Testing
Storybook
✅ Checklist