-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow very long words in banner to break to another line #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@atmgrifter00 would you mind buddying? |
atmgrifter00
approved these changes
Jun 3, 2024
rajsite
reviewed
Jun 4, 2024
rajsite
approved these changes
Jun 4, 2024
jattasNI
reviewed
Jun 4, 2024
jattasNI
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Fixes #2153
π©βπ» Implementation
overflow-wrap: anywhere
on the banner. This causes long words to first be wrapped to a new line, but if they still overflow, then the word is broken at the point it would overflow.white-space: nowrap
from the banner title styling because it was causing some/all of the action button/link and close control to be out-of-view when both the title and the button/link text were long. See Chromatic diff for details.π§ͺ Testing
Storybook
β Checklist