-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select list option groups #2111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o list-option-groups
…o list-option-groups
mollykreis
requested changes
May 16, 2024
packages/nimble-components/src/list-option-group/tests/list-option-group.spec.ts
Outdated
Show resolved
Hide resolved
mollykreis
reviewed
May 17, 2024
jattasNI
reviewed
Jun 3, 2024
Closed
Closed
jattasNI
approved these changes
Jun 3, 2024
packages/nimble-components/src/list-option-group/tests/list-option-group.spec.ts
Outdated
Show resolved
Hide resolved
…tion-group.spec.ts Co-authored-by: Jesse Attas <[email protected]>
rajsite
approved these changes
Jun 3, 2024
packages/nimble-components/src/combobox/tests/combobox.foundation.spec.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/select/testing/select.pageobject.internal.ts
Outdated
Show resolved
Hide resolved
@atmgrifter00 I think the richtext changes are trivial and non-breaking so don't need to wait for @vivinkrishna-ni |
rajsite
reviewed
Jun 3, 2024
packages/nimble-components/src/list-option-group/tests/list-option-group.spec.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
This PR only introduces groups to the
Select
. Providing this feature for theCombobox
will be handled separately.👩💻 Implementation
Introduces the
ListOptionGroup
component. This component required some APIs that manage the visibility of visual separators between groups and other visuals. This management occurs by theSelect
handling when thehidden
orvisibilityHidden
state of aListOptionGroup
changes and then updating the necessary states on both the group that changed its hidden state and the adjacent groups if present. TheListOptionGroup
manages its ownvisibilityHidden\hidden
state based on the aggregate state of its containedListOption
s.I've also changed the
ListOption
to assign itself to theoption
slot that now exists in both theListOptionGroup
template and all of the various dropdown components (i.e.Select
,Combobox
, andRichTextMentionListbox
). This follows a similar pattern to that of theTabs
component and its related pieces.Out of scope:
Select
itself. For now, if a client provides animble-list-option-group
within anothernimble-list-option-group
, nothing will get displayed in the dropdown, but no exception is thrown. The documentation currently states that this is unsupported.🧪 Testing
Unit tests. Matrix tests.
✅ Checklist