Spec for nimble-card component #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollykreis
reviewed
Oct 23, 2023
change/@ni-nimble-components-6aa0f191-427b-4745-9425-f602170a1266.json
Outdated
Show resolved
Hide resolved
change/@ni-nimble-components-6aa0f191-427b-4745-9425-f602170a1266.json
Outdated
Show resolved
Hide resolved
mollykreis
approved these changes
Oct 24, 2023
kjohn1922
requested review from
rajsite,
jattasNI and
atmgrifter00
as code owners
jattasNI
reviewed
Oct 24, 2023
jattasNI
approved these changes
Oct 25, 2023
atmgrifter00
approved these changes
Oct 25, 2023
rajsite
approved these changes
Oct 27, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
We want to introduce a nimble-card component for the new Routines UX in SLE. See the initial feature HLD here:
Feature Design: No code Routines creation
This type of component has previously been requested for other use cases as well:
GitHub Issue #296: nimble-card component
This is a draft of a spec doc
👩💻 Implementation
Added README under
nimble-components/src/card/specs.See prototype branch here: https://github.com/ni/nimble/tree/users/kelseyj/card-prototype
🧪 Testing
N/A
✅ Checklist
- [ ] I have updated the project documentation to reflect my changes or determined no changes are needed.