-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich text editor | Enable input rules for specific formatting options #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikisekarNI
approved these changes
Sep 19, 2023
change/@ni-nimble-components-d0517ff8-95e8-4312-b8d6-92b04d72a666.json
Outdated
Show resolved
Hide resolved
Co-authored-by: vikisekarNI <[email protected]>
@m-akinc Can we get a buddy review for this PR? |
m-akinc
approved these changes
Sep 19, 2023
packages/nimble-components/src/rich-text/editor/tests/rich-text-editor.spec.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/rich-text/editor/tests/rich-text-editor.spec.ts
Outdated
Show resolved
Hide resolved
jattasNI
reviewed
Sep 20, 2023
packages/nimble-components/src/rich-text/editor/tests/rich-text-editor.spec.ts
Outdated
Show resolved
Hide resolved
…ithub.com/ni/nimble into users/vivin/disable-input-rules-for-marks
…ithub.com/ni/nimble into users/vivin/disable-input-rules-for-marks
…ithub.com/ni/nimble into users/vivin/disable-input-rules-for-marks
jattasNI
approved these changes
Sep 20, 2023
rajsite
reviewed
Sep 20, 2023
packages/nimble-components/src/rich-text/editor/tests/rich-text-editor.spec.ts
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Fixes Bug 2525772: Rich text editor | Markdown input for bold and italics are converting the text to its formatting
By default, Tiptap enables input rules for all formatting options such as bold, italics, bullet list, and numbered list. Typing the following tests will convert the plain text to formatted texts in the editor,
**Bold**
or__Bold__
*Italics*
or_Italics_
*
or+
or-
1.
or any number with a periodThis might create confusion for the user, as it raises the question of whether all markdown input into the editor will change the formatting. However, these input rules will not work if we enter
***Bold and Italics***
because the combination of marks is not supported in the Tiptap editor.👩💻 Implementation
enableInputRules
while initializing the editor.false
toenablePasteRules
while initializing the editor.🧪 Testing
✅ Checklist