Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Playwright from Renovate config #1545

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

jattasNI
Copy link
Contributor

Pull Request

🤨 Rationale

Milan pointed out Renovate will fail to update Playwright because:

  1. there is no Nuget version corresponding to the latest NPM version
  2. there was a breaking change between 1.37 and 1.38

This will block automatic updates for all of our devDependencies.

👩‍💻 Implementation

  1. Remove Playwright from the list of dev dependencies updated by Renovate
  2. Filed tech debt Uptake newer Playwright version and fix breaking change #1544 to address this

🧪 Testing

Once this goes in I'll inspect #1537 to ensure it no longer lists Playwright

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@jattasNI jattasNI mentioned this pull request Sep 18, 2023
1 task
@jattasNI jattasNI enabled auto-merge (squash) September 18, 2023 13:48
@jattasNI jattasNI merged commit cc709bb into main Sep 18, 2023
10 checks passed
@jattasNI jattasNI deleted the renovate-no-playwright branch September 18, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants