Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp rich text components folder structure #1472

Merged
merged 30 commits into from
Sep 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
1c0e577
restructure folder changes
vivinkrishna-ni Aug 31, 2023
fa86b5a
Fix component import in angular
vivinkrishna-ni Aug 31, 2023
c7f895d
Fixing build issue in angular viewer module
vivinkrishna-ni Aug 31, 2023
01afe47
Updated the markdown serializer class
vivinkrishna-ni Aug 31, 2023
bafbe48
Renaming the initialization markdown serializer method
vivinkrishna-ni Aug 31, 2023
91bb520
Fix lint errors
vivinkrishna-ni Aug 31, 2023
3a70156
Change files
vivinkrishna-ni Aug 31, 2023
d37e001
Update change file description
vivinkrishna-ni Aug 31, 2023
d9d06de
Merge branch 'main' into users/vivin/revamp-rich-text-components
vivinkrishna-ni Sep 1, 2023
2c2d5ac
Resolve merge conflicts
vivinkrishna-ni Sep 1, 2023
b7fe9d8
Update editor component paths for rich text editor
vivinkrishna-ni Sep 1, 2023
b819d0e
Updating pageobject paths for angular files
vivinkrishna-ni Sep 1, 2023
4acdff3
Resolve merge conflicts
vivinkrishna-ni Sep 1, 2023
ee47b00
Merge branch 'main' into users/vivin/revamp-rich-text-components
vivinkrishna-ni Sep 1, 2023
fdc3cf7
Updated serialize method name
vivinkrishna-ni Sep 1, 2023
65acbd7
Moved the parser initialization in viewer component just like the edi…
vivinkrishna-ni Sep 1, 2023
efa562a
Merge branch 'main' into users/vivin/revamp-rich-text-components
vivinkrishna-ni Sep 1, 2023
b38df31
Resolve PR comments
vivinkrishna-ni Sep 4, 2023
719e0b7
Merge branch 'users/vivin/revamp-rich-text-components' of https://git…
vivinkrishna-ni Sep 4, 2023
b485046
Merge branch 'main' into users/vivin/revamp-rich-text-components
vivinkrishna-ni Sep 4, 2023
163de0e
Moved the specs folder to common rich-text folder
vivinkrishna-ni Sep 4, 2023
f3c7c13
Merge branch 'main' into users/vivin/revamp-rich-text-components
vivinkrishna-ni Sep 5, 2023
ea5b737
Merge branch 'main' into users/vivin/revamp-rich-text-components
vivinkrishna-ni Sep 5, 2023
c2c6367
Resolving PR comments
vivinkrishna-ni Sep 6, 2023
6c9de89
Minor import order in viewer spec
vivinkrishna-ni Sep 6, 2023
42eaa06
Merge branch 'main' into users/vivin/revamp-rich-text-components
vivinkrishna-ni Sep 6, 2023
7454fa1
Merge branch 'main' into users/vivin/revamp-rich-text-components
vivinkrishna-ni Sep 6, 2023
0657434
Update paths for label spec file
vivinkrishna-ni Sep 6, 2023
72f4b02
Merge branch 'main' into users/vivin/revamp-rich-text-components
vivinkrishna-ni Sep 6, 2023
d8a6e45
Merge branch 'main' into users/vivin/revamp-rich-text-components
vivinkrishna-ni Sep 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ import { NimbleTableColumnDateTextModule } from '@ni/nimble-angular/table-column
import { NimbleTableColumnEnumTextModule } from '@ni/nimble-angular/table-column/enum-text';
import { NimbleTableColumnIconModule } from '@ni/nimble-angular/table-column/icon';
import { NimbleTableColumnNumberTextModule } from '@ni/nimble-angular/table-column/number-text';
import { NimbleRichTextViewerModule } from '@ni/nimble-angular/rich-text-viewer';
import { NimbleRichTextEditorModule } from '@ni/nimble-angular/rich-text-editor';
import { NimbleRichTextViewerModule } from '@ni/nimble-angular/rich-text/viewer';
import { NimbleRichTextEditorModule } from '@ni/nimble-angular/rich-text/editor';
import { AppComponent } from './app.component';
import { CustomAppComponent } from './customapp/customapp.component';
import { HeaderComponent } from './header/header.component';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Component, Inject, ViewChild } from '@angular/core';
import { ActivatedRoute } from '@angular/router';
import { DrawerLocation, MenuItem, NimbleDialogDirective, NimbleDrawerDirective, OptionNotFound, OPTION_NOT_FOUND, UserDismissed } from '@ni/nimble-angular';
import type { TableRecord } from '@ni/nimble-angular/table';
import { NimbleRichTextEditorDirective } from '@ni/nimble-angular/rich-text-editor';
import { NimbleRichTextEditorDirective } from '@ni/nimble-angular/rich-text/editor';
import { BehaviorSubject, Observable } from 'rxjs';

interface ComboboxItem {
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Directive, ElementRef, EventEmitter, HostListener, Input, Output, Renderer2 } from '@angular/core';
import type { RichTextEditor } from '@ni/nimble-components/dist/esm/rich-text-editor';
import type { RichTextEditor } from '@ni/nimble-components/dist/esm/rich-text/editor';
import { BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';

export type { RichTextEditor };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { NimbleRichTextEditorDirective } from './nimble-rich-text-editor.directive';

import '@ni/nimble-components/dist/esm/rich-text-editor';
import '@ni/nimble-components/dist/esm/rich-text/editor';

@NgModule({
declarations: [NimbleRichTextEditorDirective],
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"$schema": "../../../../../../../node_modules/ng-packagr/ng-package.schema.json",
"lib": {
"entryFile": "public-api.ts"
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { RichTextEditorPageObject } from '@ni/nimble-components/dist/esm/rich-text-editor/testing/rich-text-editor.pageobject';
import type { ToolbarButton } from '@ni/nimble-components/dist/esm/rich-text-editor/testing/types';
import { RichTextEditorPageObject } from '@ni/nimble-components/dist/esm/rich-text/editor/testing/rich-text-editor.pageobject';
import type { ToolbarButton } from '@ni/nimble-components/dist/esm/rich-text/editor/testing/types';

export { RichTextEditorPageObject };
export type { ToolbarButton };
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Directive, ElementRef, Input, Renderer2 } from '@angular/core';
import type { RichTextViewer } from '@ni/nimble-components/dist/esm/rich-text-viewer';
import type { RichTextViewer } from '@ni/nimble-components/dist/esm/rich-text/viewer';

export type { RichTextViewer };

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { NimbleRichTextViewerDirective } from './nimble-rich-text-viewer.directive';

import '@ni/nimble-components/dist/esm/rich-text-viewer';
import '@ni/nimble-components/dist/esm/rich-text/viewer';

@NgModule({
declarations: [NimbleRichTextViewerDirective],
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"$schema": "../../../../../../../node_modules/ng-packagr/ng-package.schema.json",
"lib": {
"entryFile": "public-api.ts"
}
}
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { RichTextViewerPageObject } from '@ni/nimble-components/dist/esm/rich-text-viewer/testing/rich-text-viewer.pageobject';
import { RichTextViewerPageObject } from '@ni/nimble-components/dist/esm/rich-text/viewer/testing/rich-text-viewer.pageobject';

export { RichTextViewerPageObject };
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Revamp folder structure for rich text components",
"packageName": "@ni/nimble-angular",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Revamp folder structure for rich text components",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
4 changes: 2 additions & 2 deletions packages/nimble-components/src/all-components.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ import './menu-item';
import './number-field';
import './radio';
import './radio-group';
import './rich-text-editor';
import './rich-text-viewer';
import './rich-text/editor';
import './rich-text/viewer';
import './select';
import './spinner';
import './switch';
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ import type { PlaceholderOptions } from '@tiptap/extension-placeholder';
import Text from '@tiptap/extension-text';
import { template } from './template';
import { styles } from './styles';
import type { ToggleButton } from '../toggle-button';
import type { ToggleButton } from '../../toggle-button';
import { TipTapNodeName } from './types';
import type { ErrorPattern } from '../patterns/error/types';
import type { ErrorPattern } from '../../patterns/error/types';

declare global {
interface HTMLElementTagNameMap {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import {
iconSize,
smallDelay,
standardPadding
} from '../theme-provider/design-tokens';
import { styles as errorStyles } from '../patterns/error/styles';
} from '../../theme-provider/design-tokens';
import { styles as errorStyles } from '../../patterns/error/styles';

export const styles = css`
${display('inline-flex')}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
import { html, ref } from '@microsoft/fast-element';
import type { RichTextEditor } from '.';
import { toolbarTag } from '../toolbar';
import { toggleButtonTag } from '../toggle-button';
import { iconBoldBTag } from '../icons/bold-b';
import { iconItalicITag } from '../icons/italic-i';
import { iconListTag } from '../icons/list';
import { iconNumberListTag } from '../icons/number-list';
import { toolbarTag } from '../../toolbar';
import { toggleButtonTag } from '../../toggle-button';
import { iconBoldBTag } from '../../icons/bold-b';
import { iconItalicITag } from '../../icons/italic-i';
import { iconListTag } from '../../icons/list';
import { iconNumberListTag } from '../../icons/number-list';
import {
richTextToggleBoldLabel,
richTextToggleItalicsLabel,
richTextToggleBulletedListLabel,
richTextToggleNumberedListLabel
} from '../label-provider/rich-text/label-tokens';
import { errorTextTemplate } from '../patterns/error/template';
import { iconExclamationMarkTag } from '../icons/exclamation-mark';
} from '../../label-provider/rich-text/label-tokens';
import { errorTextTemplate } from '../../patterns/error/template';
import { iconExclamationMarkTag } from '../../icons/exclamation-mark';

// prettier-ignore
export const template = html<RichTextEditor>`
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { keySpace, keyEnter, keyTab } from '@microsoft/fast-web-utilities';
import type { RichTextEditor } from '..';
import { waitForUpdatesAsync } from '../../testing/async-helpers';
import type { ToggleButton } from '../../toggle-button';
import { waitForUpdatesAsync } from '../../../testing/async-helpers';
import type { ToggleButton } from '../../../toggle-button';
import type { ToolbarButton } from './types';

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import { html } from '@microsoft/fast-element';
import { richTextEditorTag, type RichTextEditor } from '..';
import { type Fixture, fixture } from '../../utilities/tests/fixture';
import { themeProviderTag, type ThemeProvider } from '../../theme-provider';
import { type Fixture, fixture } from '../../../utilities/tests/fixture';
import { themeProviderTag, type ThemeProvider } from '../../../theme-provider';
import {
LabelProviderRichText,
labelProviderRichTextTag
} from '../../label-provider/rich-text';
} from '../../../label-provider/rich-text';
import { RichTextEditorPageObject } from '../testing/rich-text-editor.pageobject';
import { LabelProvider, ToolbarButton } from '../testing/types';
import { getSpecTypeByNamedList } from '../../utilities/tests/parameterized';
import { waitForUpdatesAsync } from '../../testing/async-helpers';
import { getSpecTypeByNamedList } from '../../../utilities/tests/parameterized';
import { waitForUpdatesAsync } from '../../../testing/async-helpers';

async function setup(): Promise<Fixture<ThemeProvider>> {
return fixture<ThemeProvider>(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,25 @@ import { html, ViewTemplate } from '@microsoft/fast-element';
import {
createMatrixThemeStory,
createStory
} from '../../utilities/tests/storybook';
} from '../../../utilities/tests/storybook';
import {
createMatrix,
sharedMatrixParameters
} from '../../utilities/tests/matrix';
import { hiddenWrapper } from '../../utilities/tests/hidden';
} from '../../../utilities/tests/matrix';
import { hiddenWrapper } from '../../../utilities/tests/hidden';
import { richTextEditorTag } from '..';
import {
cssPropertyFromTokenName,
tokenNames
} from '../../theme-provider/design-token-names';
import { buttonTag } from '../../button';
import { loremIpsum } from '../../utilities/tests/lorem-ipsum';
} from '../../../theme-provider/design-token-names';
import { buttonTag } from '../../../button';
import { loremIpsum } from '../../../utilities/tests/lorem-ipsum';
import {
DisabledState,
ErrorState,
disabledStates,
errorStates
} from '../../utilities/tests/states';
} from '../../../utilities/tests/states';

const metadata: Meta = {
title: 'Tests/Rich Text Editor',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { html } from '@microsoft/fast-element';
import { richTextEditorTag, RichTextEditor } from '..';
import { type Fixture, fixture } from '../../utilities/tests/fixture';
import { getSpecTypeByNamedList } from '../../utilities/tests/parameterized';
import { type Fixture, fixture } from '../../../utilities/tests/fixture';
import { getSpecTypeByNamedList } from '../../../utilities/tests/parameterized';
import { RichTextEditorPageObject } from '../testing/rich-text-editor.pageobject';
import { wackyStrings } from '../../utilities/tests/wacky-strings';
import type { Button } from '../../button';
import type { ToggleButton } from '../../toggle-button';
import { wackyStrings } from '../../../utilities/tests/wacky-strings';
import type { Button } from '../../../button';
import type { ToggleButton } from '../../../toggle-button';
import { ToolbarButton } from '../testing/types';
import { createEventListener } from '../../utilities/tests/component';
import { createEventListener } from '../../../utilities/tests/component';

async function setup(): Promise<Fixture<RichTextEditor>> {
return fixture<RichTextEditor>(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ import { withActions } from '@storybook/addon-actions/decorator';
import {
createUserSelectedThemeStory,
incubatingWarning
} from '../../utilities/tests/storybook';
} from '../../../utilities/tests/storybook';
import { RichTextEditor, richTextEditorTag } from '..';
import { buttonTag } from '../../button';
import { buttonTag } from '../../../button';
import {
addLabelUseMetadata,
type LabelUserArgs
} from '../../label-provider/base/tests/label-user-stories-utils';
import { labelProviderRichTextTag } from '../../label-provider/rich-text';
} from '../../../label-provider/base/tests/label-user-stories-utils';
import { labelProviderRichTextTag } from '../../../label-provider/rich-text';

// eslint-disable-next-line @typescript-eslint/no-empty-interface
interface RichTextEditorArgs extends LabelUserArgs {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
bodyFontColor,
linkActiveFontColor,
linkFontColor
} from '../theme-provider/design-tokens';
} from '../../theme-provider/design-tokens';

export const styles = css`
${display('flex')}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@ import { html, ViewTemplate } from '@microsoft/fast-element';
import {
createMatrixThemeStory,
createStory
} from '../../utilities/tests/storybook';
} from '../../../utilities/tests/storybook';
import {
createMatrix,
sharedMatrixParameters
} from '../../utilities/tests/matrix';
import { hiddenWrapper } from '../../utilities/tests/hidden';
} from '../../../utilities/tests/matrix';
import { hiddenWrapper } from '../../../utilities/tests/hidden';
import { richTextViewerTag } from '..';
import { richTextMarkdownString } from '../../utilities/tests/rich-text-markdown-string';
import { loremIpsum } from '../../utilities/tests/lorem-ipsum';
import { richTextMarkdownString } from '../../../utilities/tests/rich-text-markdown-string';
import { loremIpsum } from '../../../utilities/tests/lorem-ipsum';
import {
cssPropertyFromTokenName,
tokenNames
} from '../../theme-provider/design-token-names';
} from '../../../theme-provider/design-token-names';

const metadata: Meta = {
title: 'Tests/Rich Text Viewer',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { html } from '@microsoft/fast-element';
import { RichTextViewer, richTextViewerTag } from '..';
import { fixture, type Fixture } from '../../utilities/tests/fixture';
import { fixture, type Fixture } from '../../../utilities/tests/fixture';
import { RichTextViewerPageObject } from '../testing/rich-text-viewer.pageobject';
import { wackyStrings } from '../../utilities/tests/wacky-strings';
import { getSpecTypeByNamedList } from '../../utilities/tests/parameterized';
import { wackyStrings } from '../../../utilities/tests/wacky-strings';
import { getSpecTypeByNamedList } from '../../../utilities/tests/parameterized';

async function setup(): Promise<Fixture<RichTextViewer>> {
return fixture<RichTextViewer>(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import type { Meta, StoryObj } from '@storybook/html';
import {
createUserSelectedThemeStory,
incubatingWarning
} from '../../utilities/tests/storybook';
} from '../../../utilities/tests/storybook';
import { richTextViewerTag } from '..';
import { richTextMarkdownString } from '../../utilities/tests/rich-text-markdown-string';
import { richTextMarkdownString } from '../../../utilities/tests/rich-text-markdown-string';

interface RichTextViewerArgs {
markdown: string;
Expand Down
Loading