Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular support for nimble-rich-text-editor #1450

Merged
merged 180 commits into from
Aug 31, 2023
Merged

Angular support for nimble-rich-text-editor #1450

merged 180 commits into from
Aug 31, 2023

Commits on Jul 6, 2023

  1. Initial pass for editor component. This is a intermediate commit and … 

    …need changes
    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ca4ccec View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Overrides semver version to be >=7.5.2

    @AagashRaaj
    AagashRaaj committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    6e15794 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Removed the tiptap packages

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    a163b55 View commit details
    Browse the repository at this point in the history

  2. Reverted the package-lock.json to main branch changes

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    6df5ef1 View commit details
    Browse the repository at this point in the history

  3. Added tiptap packages and necessary packages for tiptap

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    38be4dd View commit details
    Browse the repository at this point in the history

  4. Component and angular skeleton code bring up for rich-text-editor

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    b159f86 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'users/vivin/initial-code-for-rich-text-editor' into use… 

    …rs/vivin/integrate-tiptap-editor
    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    37e1062 View commit details
    Browse the repository at this point in the history

  6. Resolved linting errors

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    0d1de1a View commit details
    Browse the repository at this point in the history

  7. Merge branch 'users/vivin/initial-code-for-rich-text-editor' into use… 

    …rs/vivin/integrate-tiptap-editor
    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    91362df View commit details
    Browse the repository at this point in the history

  8. Removed angular code from this branch and will be added as separate PR

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    70a5c2d View commit details
    Browse the repository at this point in the history

  9. Removed constant file file for rich-text-content

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    0a68e83 View commit details
    Browse the repository at this point in the history

  10. Change files

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    6bdd0d7 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'users/vivin/initial-code-for-rich-text-editor' into use… 

    …rs/vivin/integrate-tiptap-editor
    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    5851a8b View commit details
    Browse the repository at this point in the history

  12. Updated the description for editor storybook

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    391ecbc View commit details
    Browse the repository at this point in the history

  13. Merge branch 'users/vivin/initial-code-for-rich-text-editor' into use… 

    …rs/vivin/integrate-tiptap-editor
    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    288aa3e View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Merge branch 'main' into users/vivin/initial-code-for-rich-text-editor

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    43330c2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'users/vivin/initial-code-for-rich-text-editor' into use… 

    …rs/vivin/integrate-tiptap-editor
    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f21a11e View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Initial bring up of titptap editor with basic template enabled

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    4c94bd4 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Merge branch 'main' into users/vivin/integrate-tiptap-editor

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    6cc6209 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Intermediate commit to add functionalities to the buttons and modifie… 

    …d few styles.
    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    560ecd5 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Added placeholder and link extensions

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    a32ade0 View commit details
    Browse the repository at this point in the history

  2. Added placeholder support rich-text-editor

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    dc8152d View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Updates on the link configurations

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    00571c1 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Intermediate changes for maxlength and disabled state

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    0468ba5 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Updated for footer hidden attribute

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9ec89cf View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Added some additional APIs to this branch, might be removed and split… 

    … into separate PRs
    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    d56355b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into users/vivin/integrate-tiptap-editor

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    33cb3c7 View commit details
    Browse the repository at this point in the history

  3. Update package lock json

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    efe79e0 View commit details
    Browse the repository at this point in the history

  4. Changes with only basic editor and footer actions

    @vivinkrishna-ni
    vivinkrishna-ni committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    ca2bf70 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Updated few code changes to re-confirm pipeline passes

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    1c39203 View commit details
    Browse the repository at this point in the history

  2. Removed markdown-it from dev dependency

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    390df6a View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Updated test case, style and implementation to integrate tiptap edito… 

    …r and footer section
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    92ddd09 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Update desc in change file and formatting in template

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e0e20eb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into users/vivin/integrate-tiptap-editor

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    3df5015 View commit details
    Browse the repository at this point in the history

  3. resolve linting errors

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    fe4b926 View commit details
    Browse the repository at this point in the history

  4. Changed the name of the private function and minor style change

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    bd29abb View commit details
    Browse the repository at this point in the history

  5. Added model class for editor button events

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    15b3fa4 View commit details
    Browse the repository at this point in the history

  6. returning void for base class methods

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    9dc2e1a View commit details
    Browse the repository at this point in the history

  7. resolve linting errors

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e67d478 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Merge branch 'main' into users/vivin/integrate-tiptap-editor

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    40633b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Resolved PR comments

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    4d3e099 View commit details
    Browse the repository at this point in the history

  2. Added internal comment for public variables

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    ad024ef View commit details
    Browse the repository at this point in the history

  3. Resolve PR comments

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    bbe0c26 View commit details
    Browse the repository at this point in the history

  4. Update minor function name change

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    6dddc0a View commit details
    Browse the repository at this point in the history

  5. resolve linting errors

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    94cafd0 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Merge branch 'main' into users/vivin/integrate-tiptap-editor

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    c1a0ca8 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Updated package-lock.json

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    0b16f24 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into users/vivin/integrate-tiptap-editor

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    9eb96e3 View commit details
    Browse the repository at this point in the history

  3. Resolving PR comments

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    21abec6 View commit details
    Browse the repository at this point in the history

  4. Updated the name for button properties and resolve linting errors

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    efa3f1e View commit details
    Browse the repository at this point in the history

  5. Added test cases for aria attributes

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    101ebb5 View commit details
    Browse the repository at this point in the history

  6. Removed fdescribe

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    2602635 View commit details
    Browse the repository at this point in the history

  7. Added comments to specify the return value for key handler

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    393f42b View commit details
    Browse the repository at this point in the history

  8. added readonly for base class properties

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    462d929 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Removed model classes and moved it to a template file

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    8e33326 View commit details
    Browse the repository at this point in the history

  2. Add setMarkdown and getmarkdown method in rich-text-editor 

    Signed-off-by: Aagash Raaj <[email protected]>
    @AagashRaaj
    AagashRaaj committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    eeaec8e View commit details
    Browse the repository at this point in the history

  3. Added labels for each buttons

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    2755e60 View commit details
    Browse the repository at this point in the history

  4. Update story book 

    Signed-off-by: Aagash Raaj <[email protected]>
    @AagashRaaj
    AagashRaaj committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0a8955d View commit details
    Browse the repository at this point in the history

  5. Fix lint 

    Signed-off-by: Aagash Raaj <[email protected]>
    @AagashRaaj
    AagashRaaj committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    c4db560 View commit details
    Browse the repository at this point in the history

  6. Minor fix 

    Signed-off-by: Aagash Raaj <[email protected]>
    @AagashRaaj
    AagashRaaj committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    924fd8b View commit details
    Browse the repository at this point in the history

  7. safari workaround

    @AagashRaaj
    AagashRaaj committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    bfb5c23 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Merge branch 'main' into users/vivin/integrate-tiptap-editor

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d0bfce2 View commit details
    Browse the repository at this point in the history

  2. Resolving PR comments

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    367491e View commit details
    Browse the repository at this point in the history

  3. Minor code changes

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2b01fff View commit details
    Browse the repository at this point in the history

  4. Updated comment in the code

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1ece855 View commit details
    Browse the repository at this point in the history

  5. updated the comment in the styles

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    54cfba0 View commit details
    Browse the repository at this point in the history

  6. resolve linting errors

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    65bd029 View commit details
    Browse the repository at this point in the history

  7. Address PR Comments

    @AagashRaaj
    AagashRaaj committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ba0f36b View commit details
    Browse the repository at this point in the history

  8. Added test cases for the change event propagation and part for footer… 

    … section
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    04db1a8 View commit details
    Browse the repository at this point in the history

  9. Minor correction in the comment added

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d8c239e View commit details
    Browse the repository at this point in the history

  10. Remove focus on setMarkdown()

    @AagashRaaj
    AagashRaaj committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2497365 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'users/vivin/integrate-tiptap-editor' of https://github.… 

    …com/ni/nimble into users/aagash/markdown-parser-serializer-editor
    @AagashRaaj
    AagashRaaj committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    5dc0216 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Added test cases for nested lists in editor and viewer

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    9d21139 View commit details
    Browse the repository at this point in the history

  2. Removed skipping escape func while serializing 

    Signed-off-by: Aagash Raaj <[email protected]>
    @AagashRaaj
    AagashRaaj committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    fc592a3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into users/vivin/integrate-tiptap-editor

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    7c5c95e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into users/vivin/integrate-tiptap-editor

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    47e92d7 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into users/vivin/integrate-tiptap-editor

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    9f27b34 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Minor test case name update

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    cd43757 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into users/vivin/integrate-tiptap-editor

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    1daf767 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Address PR comments

    @AagashRaaj
    AagashRaaj committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    84e56dc View commit details
    Browse the repository at this point in the history

  2. Remove types.ts file

    @AagashRaaj
    AagashRaaj committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    748c780 View commit details
    Browse the repository at this point in the history

  3. Fix linting

    @AagashRaaj
    AagashRaaj committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    b845367 View commit details
    Browse the repository at this point in the history

  4. Refactored page object and updated the test cases accordingly

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    aa4045c View commit details
    Browse the repository at this point in the history

  5. Updated the nested list test cases in viewer component

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    567fd0c View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Resolving PR comments

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    ef70cda View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into users/vivin/integrate-tiptap-editor

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    dfb9cd8 View commit details
    Browse the repository at this point in the history

  3. Updated the default height of the container for sizing tests

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    f211efc View commit details
    Browse the repository at this point in the history

  4. Merge branch 'users/vivin/integrate-tiptap-editor' of https://github.… 

    …com/ni/nimble into users/vivin/integrate-tiptap-editor
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    afe3cdf View commit details
    Browse the repository at this point in the history

  5. Address PR comments

    @AagashRaaj
    AagashRaaj committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c49bcba View commit details
    Browse the repository at this point in the history

  6. Minor fix

    @AagashRaaj
    AagashRaaj committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c3e7f8f View commit details
    Browse the repository at this point in the history

  7. Fix lint

    @AagashRaaj
    AagashRaaj committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    f6188f2 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'users/vivin/integrate-tiptap-editor' of https://github.… 

    …com/ni/nimble into users/aagash/markdown-parser-serializer-editor
    @AagashRaaj
    AagashRaaj committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    12dd3f0 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Updated the aria-multiline value by using setAttribute

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    9f5b675 View commit details
    Browse the repository at this point in the history

  2. Typo correction for aria-multiline attribute

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    43f52ac View commit details
    Browse the repository at this point in the history

  3. Added titles for buttons and moved enum to a type file

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    31cac04 View commit details
    Browse the repository at this point in the history

  4. Added spec file for types

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    8db2b7f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into users/vivin/integrate-tiptap-editor

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    0b58903 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'users/vivin/integrate-tiptap-editor' into users/aagash/… 

    …markdown-parser-serializer-editor
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    afe4eca View commit details
    Browse the repository at this point in the history

  7. Merge branch 'users/aagash/markdown-parser-serializer-editor' of http… 

    …s://github.com/ni/nimble into users/aagash/markdown-parser-serializer-editor
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    fe8de41 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into users/aagash/markdown-parser-serializer-editor

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    da25204 View commit details
    Browse the repository at this point in the history

  9. Removed change file

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    9d32990 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'users/aagash/markdown-parser-serializer-editor' of http… 

    …s://github.com/ni/nimble into users/aagash/markdown-parser-serializer-editor
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    60ee9c7 View commit details
    Browse the repository at this point in the history

  11. Fix linting

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    0823fe3 View commit details
    Browse the repository at this point in the history

  12. Passed enum types to the methods in page objects instead of number type

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    14bb516 View commit details
    Browse the repository at this point in the history

  13. Change files

    @jattasNI
    jattasNI committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    d1b0955 View commit details
    Browse the repository at this point in the history

  14. typo

    @jattasNI
    jattasNI committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    bfa0f2e View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Update Comments

    @AagashRaaj
    AagashRaaj committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    7252c97 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into users/aagash/markdown-parser-serializer-editor

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    33611bd View commit details
    Browse the repository at this point in the history

  3. Additional APIs for rich text editor

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e6f7e12 View commit details
    Browse the repository at this point in the history

  4. Add testcase for editor Before DOM Connection

    @AagashRaaj
    AagashRaaj committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8460c85 View commit details
    Browse the repository at this point in the history

  5. Minor renaming

    @AagashRaaj
    AagashRaaj committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e9a4548 View commit details
    Browse the repository at this point in the history

  6. Check getMarkdown() before dom initialization

    @AagashRaaj
    AagashRaaj committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    65a4b96 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Test case update due to the version update and placeholder code change

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    1742dfb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'users/aagash/markdown-parser-serializer-editor' into us… 

    …ers/vivin/editor-ui-api
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3efae7c View commit details
    Browse the repository at this point in the history

  3. Removed waitForUpdatesAsync from the disabled API test cases

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    61391b5 View commit details
    Browse the repository at this point in the history

  4. angular integration get and set markdown

    @AagashRaaj
    AagashRaaj committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3544c6b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into users/vivin/editor-ui-api

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    5fece27 View commit details
    Browse the repository at this point in the history

  6. Resolve commit for initial PR comments

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    0570cc4 View commit details
    Browse the repository at this point in the history

  7. Change files

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9481f5d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into users/vivin/editor-ui-api

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    82b4853 View commit details
    Browse the repository at this point in the history

  9. Removed aria-disabled for toggle buttons

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    a6fd7f0 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'users/vivin/editor-ui-api' of https://github.com/ni/nimble 

     into users/vivin/editor-ui-api
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    5edc8bd View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Resolving the comments

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b04b9ac View commit details
    Browse the repository at this point in the history

  2. Minor changes in the code comments and in height

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    8008934 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into users/vivin/editor-ui-api

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3fed861 View commit details
    Browse the repository at this point in the history

  4. Minor style changes related to footer-hidden attribute

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0e9bd3b View commit details
    Browse the repository at this point in the history

  5. Fixing the test case for footer hidden attribute

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    031d672 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'users/vivin/editor-ui-api' into users/vivin/editor-angu… 

    …lar-integration
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    a87f199 View commit details
    Browse the repository at this point in the history

  7. Typo correction in the empty property comment in the code 

    Co-authored-by: m-akinc <[email protected]>
    @vivinkrishna-ni @m-akinc
    vivinkrishna-ni and m-akinc authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    33778eb View commit details
    Browse the repository at this point in the history

  8. Support for angular directive

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b058f59 View commit details
    Browse the repository at this point in the history

  9. Updated placeholder test case

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    6df4347 View commit details
    Browse the repository at this point in the history

  10. Change files

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c1ee56b View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Removed unused styles and rearranged directive methods

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    86df7f0 View commit details
    Browse the repository at this point in the history

  2. Minor update in the spec

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    83ba6f8 View commit details
    Browse the repository at this point in the history

  3. Removed setting visibility in footer section

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    ab09e13 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'users/vivin/editor-ui-api' into users/vivin/editor-angu… 

    …lar-integration
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    491afbc View commit details
    Browse the repository at this point in the history

  5. Resolving PR comments

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    f048ad6 View commit details
    Browse the repository at this point in the history

  6. Removed setting markdown in the client app

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    8dea1af View commit details
    Browse the repository at this point in the history

  7. Removed unnecessary imports in the client component

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    965a891 View commit details
    Browse the repository at this point in the history

  8. Added slot button

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    d7cc526 View commit details
    Browse the repository at this point in the history

  9. Removed slot button

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    781d97a View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Updated the example app by adding slot button and set markdown content

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    7c7b622 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into users/vivin/editor-ui-api

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    fa1c8ba View commit details
    Browse the repository at this point in the history

  3. Merge branch 'users/vivin/editor-ui-api' into users/vivin/editor-angu… 

    …lar-integration
    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    1d588a7 View commit details
    Browse the repository at this point in the history

  4. Resolve merge conflicts

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 25, 2023
    Configuration menu
    Copy the full SHA
    bf68596 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. Resolve PR comments

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    007365b View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Resolving PR comments for fit to content related changes

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    b398040 View commit details
    Browse the repository at this point in the history

  2. Added test case to test input event is not firing when setting throug… 

    …h setMarkdown
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e1c1c53 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into users/vivin/editor-ui-api

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8919ed5 View commit details
    Browse the repository at this point in the history

  4. fix minor errors

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    4b3ffc9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'users/vivin/editor-ui-api' of https://github.com/ni/nimble 

     into users/vivin/editor-ui-api
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    78e578c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into users/vivin/editor-ui-api

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    56f6fbf View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Resolve comments for aria-label

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    b3e5d6a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'users/vivin/editor-ui-api' of https://github.com/ni/nimble 

     into users/vivin/editor-ui-api
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2c4fbae View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into users/vivin/editor-ui-api

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    40ffe0a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'users/vivin/editor-ui-api' into users/vivin/editor-angu… 

    …lar-integration
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    3664aea View commit details
    Browse the repository at this point in the history

  5. Merge branch 'users/vivin/editor-angular-integration' of https://gith… 

    …ub.com/ni/nimble into users/vivin/editor-angular-integration
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    513be08 View commit details
    Browse the repository at this point in the history

  6. Added entry points for page object files in editor and viewer

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    8367ee2 View commit details
    Browse the repository at this point in the history

  7. resolving PR comments

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4132b06 View commit details
    Browse the repository at this point in the history

  8. Exports the toolbar button type for the editor page object

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    3518bcf View commit details
    Browse the repository at this point in the history

  9. Merge branch 'users/vivin/editor-ui-api' into users/vivin/editor-angu… 

    …lar-integration
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4884a84 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into users/vivin/editor-ui-api

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    9a12f91 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Resolving PR comments without the changes for fit to content

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    4ebbdba View commit details
    Browse the repository at this point in the history

  2. Merge branch 'users/vivin/editor-ui-api' of https://github.com/ni/nimble 

     into users/vivin/editor-ui-api
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    4d0e8a2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into users/vivin/editor-ui-api

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    255557d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'users/vivin/editor-ui-api' into users/vivin/editor-angu… 

    …lar-integration
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    48c0cfd View commit details
    Browse the repository at this point in the history

  5. Updated the placeholder to be string or undefined as it is updated in… 

    … the previous PR
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    883efdc View commit details
    Browse the repository at this point in the history

  6. Removed all fit to content related changes and planning to move it to… 

    … the follow up PR.
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    e754931 View commit details
    Browse the repository at this point in the history

  7. Updated the comment for the placeholder class.

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    0c0094c View commit details
    Browse the repository at this point in the history

  8. Showing the error icon only after the width calculated.

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    235427b View commit details
    Browse the repository at this point in the history

  9. Fix lint errors

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    e679b67 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'users/vivin/editor-ui-api' into users/vivin/editor-angu… 

    …lar-integration
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    63b3f78 View commit details
    Browse the repository at this point in the history

  11. Removed fit-to-content attribute as it is removed from the component PR

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    5200508 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Updated scrollbar-width-calculated to a class instead of attribute

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    5083656 View commit details
    Browse the repository at this point in the history

  2. Updated scrollbar width calculation as a class and not an attribute

    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    487d95c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into users/vivin/editor-ui-api

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    f1b8e07 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'users/vivin/editor-ui-api' into users/vivin/editor-angu… 

    …lar-integration
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    6886863 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'users/vivin/editor-angular-integration' of https://gith… 

    …ub.com/ni/nimble into users/vivin/editor-angular-integration
    @vivinkrishna-ni
    vivinkrishna-ni committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    37a24ea View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into users/vivin/editor-angular-integration

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    84e8fa8 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into users/vivin/editor-angular-integration

    @vivinkrishna-ni
    vivinkrishna-ni authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    4ca3caa View commit details
    Browse the repository at this point in the history