-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Checkbox error state HLD update (#2467)
# Pull Request ## 🤨 Rationale During development of #2018, I realized that implementing the error state of the checkbox the way it was spec'ed out would be much more difficult than originally thought because making only the label and square checked indicator clickable would break a number of tests (inside & outside of nimble) and would be against ARIA guidelines. Therefore, we decided to keep the effort of the feature more in line with what our original estimates were by deferring the work to update which portion of the control was clickable. ## 👩💻 Implementation Update HLD ## 🧪 Testing None ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [ ] I have updated the project documentation to reflect my changes or determined no changes are needed.
- Loading branch information
1 parent
7a0ba9a
commit 6b0daf9
Showing
9 changed files
with
14 additions
and
11 deletions.
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@ni-nimble-components-b2fe6cda-830f-4aea-8378-049b1f65f3be.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "none", | ||
"comment": "Update checkbox error state HLD to move plan to update clickable region of the control to future work", | ||
"packageName": "@ni/nimble-components", | ||
"email": "[email protected]", | ||
"dependentChangeType": "none" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file removed
BIN
-2.39 KB
...ges/nimble-components/src/checkbox/specs/spec-images/checkbox-error,no_wrap.PNG
Binary file not shown.
Binary file removed
BIN
-5.06 KB
packages/nimble-components/src/checkbox/specs/spec-images/checkbox-error,wrap.PNG
Binary file not shown.
Binary file removed
BIN
-3.41 KB
packages/nimble-components/src/checkbox/specs/spec-images/checkbox-long_error.PNG
Binary file not shown.
Binary file removed
BIN
-1.5 KB
.../nimble-components/src/checkbox/specs/spec-images/checkbox-no_error,no_wrap.PNG
Binary file not shown.
Binary file removed
BIN
-4.19 KB
...ges/nimble-components/src/checkbox/specs/spec-images/checkbox-no_error,wrap.PNG
Binary file not shown.
Binary file added
BIN
+2.19 KB
packages/nimble-components/src/checkbox/specs/spec-images/checkbox-with-error.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.71 KB
...s/nimble-components/src/checkbox/specs/spec-images/checkbox-with-long-error.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.