Skip to content

Commit

Permalink
Manually update Plawright to 1.42.0 (#1956)
Browse files Browse the repository at this point in the history
# Pull Request

## 🤨 Rationale

#1747 has a recurring maintenance task to update the version of
Playwright to the latest version that's available in npm and Nuget. We
were on 1.40.0, the [latest on npm is
1.42.1](https://www.npmjs.com/package/playwright?activeTab=versions),
and the [latest on Nuget is
1.42.0](https://www.nuget.org/packages/Microsoft.Playwright)

[Detailed release
notes](https://github.com/microsoft/playwright/releases).

## 👩‍💻 Implementation

1. Searched for "1.40.0" in package.json files and updated to "1.42.0".
2. Ran `npm install` to regenerate package-lock.json

## 🧪 Testing

1. Verified locally that
`packages/nimble-blazor/build/generate-playwright-version-properties/dist/Playwright.PackageVersion.props`
is regenerated and the build and test commands pass.
2. Otherwise relying on PR build

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [ ] I have updated the project documentation to reflect my changes or
determined no changes are needed.
  • Loading branch information
jattasNI authored Mar 22, 2024
1 parent 9c6adb4 commit 559c12f
Show file tree
Hide file tree
Showing 9 changed files with 38 additions and 17 deletions.
2 changes: 1 addition & 1 deletion angular-workspace/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"karma-jasmine": "^5.1.0",
"karma-jasmine-html-reporter": "^2.0.0",
"ng-packagr": "^15.2.2",
"playwright": "1.40.0",
"playwright": "1.42.0",
"rollup": "^4.12.0",
"typescript": "~4.9.5"
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Update Playwright dev dependency to 1.42.0",
"packageName": "@ni/jasmine-parameterized",
"email": "[email protected]",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Update Playwright dev dependency to 1.42.0",
"packageName": "@ni/nimble-blazor",
"email": "[email protected]",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Update Playwright dev dependency to 1.42.0",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "none"
}
24 changes: 12 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,6 @@
"beachball": "^2.31.0",
"cross-env": "^7.0.3",
"patch-package": "^8.0.0",
"playwright": "1.40.0"
"playwright": "1.42.0"
}
}
2 changes: 1 addition & 1 deletion packages/jasmine-parameterized/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"karma-jasmine": "^5.1.0",
"karma-jasmine-html-reporter": "^2.0.0",
"karma-spec-reporter": "^0.0.36",
"playwright": "1.40.0",
"playwright": "1.42.0",
"typescript": "~4.9.5"
}
}
2 changes: 1 addition & 1 deletion packages/nimble-blazor/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"@rollup/plugin-node-resolve": "^15.0.1",
"cross-env": "^7.0.3",
"glob": "^10.3.10",
"playwright": "1.40.0",
"playwright": "1.42.0",
"rimraf": "^5.0.5",
"rollup": "^4.12.0"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/nimble-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
"karma-spec-reporter": "^0.0.36",
"karma-webkit-launcher": "^2.1.0",
"karma-webpack": "^5.0.0",
"playwright": "1.40.0",
"playwright": "1.42.0",
"prettier-eslint": "^16.3.0",
"prettier-eslint-cli": "^8.0.1",
"remark-gfm": "^3.0.1",
Expand Down

0 comments on commit 559c12f

Please sign in to comment.