Skip to content

Commit

Permalink
Fix table row rendering in Safari (#998)
Browse files Browse the repository at this point in the history
# Pull Request

## 🀨 Rationale

Fixes #984 

## πŸ‘©β€πŸ’» Implementation

As @rajsite and @msmithNI suggested in the linked issue, use
`this.$fastController.isConnected` instead of `this.isConnected` in the
table cell's `cellTemplateChanged()` method.

## πŸ§ͺ Testing

I manually tested in Safari in Storybook and the Angular example app.
Malcolm tested in Playwright's Safari.

Auto tests would be covered by #990.

## βœ… Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
  • Loading branch information
jattasNI authored Jan 26, 2023
1 parent 4c2904a commit 2e5a1c8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix table row rendering on Safari",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export class TableCell<
}

protected cellTemplateChanged(): void {
if (this.isConnected) {
if (this.$fastController.isConnected) {
this.customCellView = this.cellTemplate?.render(
this.cellState,
this.cellContentContainer
Expand Down

0 comments on commit 2e5a1c8

Please sign in to comment.