Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for trigger APIs #597

Merged
merged 2 commits into from
Jun 17, 2024
Merged

add tests for trigger APIs #597

merged 2 commits into from
Jun 17, 2024

Conversation

jlin-NI
Copy link
Collaborator

@jlin-NI jlin-NI commented Jun 14, 2024

What does this Pull Request accomplish?

add python test for trigger APIs

Why should this Pull Request be merged?

several trigger C APIs are not tested by python test, add test to set appropriate trigger attribute, read back and check attribute values, also add 6535 simulated device for digital pattern.

What testing has been done?

poetry run pytest .\tests\component\task\test_triggers.py

Copy link
Collaborator

@zhindes zhindes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change for disabling Linux

tests/max_config/linux/nidaqmxMaxConfig.ini Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
tests/component/task/test_triggers.py Outdated Show resolved Hide resolved
tests/component/task/test_triggers.py Outdated Show resolved Hide resolved
tests/component/task/test_triggers.py Outdated Show resolved Hide resolved
tests/max_config/nidaqmxMaxConfig.ini Outdated Show resolved Hide resolved
Copy link

Test Results

    34 files  ±  0      34 suites  ±0   47m 53s ⏱️ + 1m 1s
 2 298 tests + 24   1 934 ✅ + 24    364 💤 ±0  0 ❌ ±0 
40 722 runs  +408  34 542 ✅ +408  6 180 💤 ±0  0 ❌ ±0 

Results for commit f8ffce0. ± Comparison against base commit 023f5bc.

@jlin-NI jlin-NI merged commit 6823c8b into master Jun 17, 2024
17 checks passed
@jlin-NI jlin-NI deleted the users/jlin/triggerTest branch June 17, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants